wikimedia/mediawiki-extensions-Wikibase

View on GitHub
repo/rest-api/src/RouteHandlers/SetPropertyLabelRouteHandler.php

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

    public function getBodyParamSettings(): array {
        return [
            self::LABEL_BODY_PARAM => [
                self::PARAM_SOURCE => 'body',
                ParamValidator::PARAM_TYPE => 'string',
repo/rest-api/src/RouteHandlers/AddItemAliasesInLanguageRouteHandler.php on lines 130..155
repo/rest-api/src/RouteHandlers/AddItemStatementRouteHandler.php on lines 136..161
repo/rest-api/src/RouteHandlers/AddPropertyAliasesInLanguageRouteHandler.php on lines 124..149
repo/rest-api/src/RouteHandlers/AddPropertyStatementRouteHandler.php on lines 144..169
repo/rest-api/src/RouteHandlers/CreateItemRouteHandler.php on lines 116..141
repo/rest-api/src/RouteHandlers/CreatePropertyRouteHandler.php on lines 117..142
repo/rest-api/src/RouteHandlers/ReplaceItemStatementRouteHandler.php on lines 138..163
repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php on lines 137..162
repo/rest-api/src/RouteHandlers/ReplaceStatementRouteHandler.php on lines 133..158
repo/rest-api/src/RouteHandlers/SetItemDescriptionRouteHandler.php on lines 110..135
repo/rest-api/src/RouteHandlers/SetItemLabelRouteHandler.php on lines 126..151
repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 105..130
repo/rest-api/src/RouteHandlers/SetSitelinkRouteHandler.php on lines 135..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 172.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public static function factory(): Handler {
        $responseFactory = new ResponseFactory();

        return new self(
            WbRestApi::getSetPropertyLabel(),
repo/rest-api/src/RouteHandlers/AddItemAliasesInLanguageRouteHandler.php on lines 56..72
repo/rest-api/src/RouteHandlers/SetItemDescriptionRouteHandler.php on lines 53..69
repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 52..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    private function newSuccessHttpResponse( SetPropertyLabelResponse $useCaseResponse ): Response {
        $httpResponse = $this->getResponseFactory()->create();
        $httpResponse->setStatus( $useCaseResponse->wasReplaced() ? 200 : 201 );
        $httpResponse->setHeader( 'Content-Type', 'application/json' );
        $httpResponse->setHeader( 'ETag', "\"{$useCaseResponse->getRevisionId()}\"" );
repo/rest-api/src/RouteHandlers/SetItemDescriptionRouteHandler.php on lines 159..173
repo/rest-api/src/RouteHandlers/SetItemLabelRouteHandler.php on lines 160..172
repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 154..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function runUseCase( string $propertyId, string $languageCode ): Response {
        $jsonBody = $this->getValidatedBody();
        '@phan-var array $jsonBody'; // guaranteed to be an array per getBodyParamSettings()
        try {
            $useCaseResponse = $this->setPropertyLabel->execute(
repo/rest-api/src/RouteHandlers/AddPropertyAliasesInLanguageRouteHandler.php on lines 81..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status