Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
view/src/Termbox/Renderer/TermboxRemoteRenderer.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getContent has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getContent( EntityId $entityId, $revision, $language, $editLink, TermLanguageFallbackChain $preferredLanguages ) {
        try {
            $request = $this->requestFactory->create(
                $this->formatUrl( $entityId, $revision, $language, $editLink, $preferredLanguages ),
                [ 'timeout' => $this->ssrServerTimeout ],
Severity: Minor
Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 1 hr to fix

    Method getRequestParams has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            EntityId $entityId,
        $revision,
        $language,
        $editLink,
        TermLanguageFallbackChain $preferredLanguages
    Severity: Minor
    Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              HttpRequestFactory $requestFactory,
        ?string $ssrServerUrl,
        $ssrServerTimeout,
        LoggerInterface $logger,
        StatsdDataFactoryInterface $stats
      Severity: Minor
      Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 35 mins to fix

        Method formatUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function formatUrl( EntityId $entityId, $revision, $language, $editLink, TermLanguageFallbackChain $preferredLanguages ) {
        Severity: Minor
        Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 35 mins to fix

          Method getContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getContent( EntityId $entityId, $revision, $language, $editLink, TermLanguageFallbackChain $preferredLanguages ) {
          Severity: Minor
          Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 35 mins to fix

            Function getContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getContent( EntityId $entityId, $revision, $language, $editLink, TermLanguageFallbackChain $preferredLanguages ) {
        try {
            $request = $this->requestFactory->create(
                $this->formatUrl( $entityId, $revision, $language, $editLink, $preferredLanguages ),
                [ 'timeout' => $this->ssrServerTimeout ],
            Severity: Minor
            Found in view/src/Termbox/Renderer/TermboxRemoteRenderer.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status