Sign upLogin

wikimedia/pywikibot

View on GitHub
Star

Showing 616 of 616 total issues

File _apisite.py has 2564 lines of code (exceeds 900 allowed). Consider refactoring.
Open

"""Objects representing API interface to MediaWiki site."""
#
# (C) Pywikibot team, 2008-2024
#
# Distributed under the terms of the MIT license.
Severity: Major
Found in pywikibot/site/_apisite.py - About 5 days to fix

    File _generators.py has 2044 lines of code (exceeds 900 allowed). Consider refactoring.
    Open

    """Objects representing API generators to MediaWiki site."""
#
# (C) Pywikibot team, 2008-2024
#
# Distributed under the terms of the MIT license.
    Severity: Major
    Found in pywikibot/site/_generators.py - About 3 days to fix

      File _wikibase.py has 1970 lines of code (exceeds 900 allowed). Consider refactoring.
      Open

      """Objects representing various types of Wikibase pages and structures.

This module also includes objects:

* Claim: an instance of a semantic assertion.
      Severity: Major
      Found in pywikibot/page/_wikibase.py - About 3 days to fix

        File site_generators_tests.py has 1927 lines of code (exceeds 900 allowed). Consider refactoring.
        Open

        #!/usr/bin/env python3
"""Tests for generators of the site module."""
#
# (C) Pywikibot team, 2008-2024
#
        Severity: Major
        Found in tests/site_generators_tests.py - About 3 days to fix

          File _basepage.py has 1879 lines of code (exceeds 900 allowed). Consider refactoring.
          Open

          """Objects representing a base object for a MediaWiki page."""
#
# (C) Pywikibot team, 2008-2024
#
# Distributed under the terms of the MIT license.
          Severity: Major
          Found in pywikibot/page/_basepage.py - About 3 days to fix

            File interwiki.py has 1860 lines of code (exceeds 900 allowed). Consider refactoring.
            Open

            #!/usr/bin/env python3
"""Script to check language links for general pages.

Uses existing translations of a page, plus hints from the command line,
to download the equivalent pages from other languages. All of such pages
            Severity: Major
            Found in scripts/interwiki.py - About 3 days to fix

              File bot.py has 1760 lines of code (exceeds 900 allowed). Consider refactoring.
              Open

              """User-interface related functions for building bots.

This module supports several different bot classes which could be used in
conjunction. Each bot should subclass at least one of these four classes:
              Severity: Major
              Found in pywikibot/bot.py - About 2 days to fix

                File date.py has 1681 lines of code (exceeds 900 allowed). Consider refactoring.
                Open

                """Date data and manipulation module."""
#
# (C) Pywikibot team, 2003-2024
#
# Distributed under the terms of the MIT license.
                Severity: Major
                Found in pywikibot/date.py - About 2 days to fix

                  File textlib.py has 1636 lines of code (exceeds 900 allowed). Consider refactoring.
                  Open

                  """Functions for manipulating wiki-text."""
#
# (C) Pywikibot team, 2008-2024
#
# Distributed under the terms of the MIT license.
                  Severity: Major
                  Found in pywikibot/textlib.py - About 2 days to fix

                    File pagegenerators_tests.py has 1469 lines of code (exceeds 900 allowed). Consider refactoring.
                    Open

                    #!/usr/bin/env python3
"""Test pagegenerators module."""
#
# (C) Pywikibot team, 2009-2024
#
                    Severity: Major
                    Found in tests/pagegenerators_tests.py - About 1 day to fix

                      File textlib_tests.py has 1407 lines of code (exceeds 900 allowed). Consider refactoring.
                      Open

                      #!/usr/bin/env python3
"""Test textlib module."""
#
# (C) Pywikibot team, 2011-2024
#
                      Severity: Major
                      Found in tests/textlib_tests.py - About 1 day to fix

                        Function review_hunks has a Cognitive Complexity of 90 (exceeds 10 allowed). Consider refactoring.
                        Open

                            def review_hunks(self) -> None:
        """Review hunks."""
        def find_pending(start: int, end: int) -> int | None:
            step = -1 if start > end else +1
            for pending in range(start, end, step):
                        Severity: Minor
                        Found in pywikibot/diff.py - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File category.py has 1363 lines of code (exceeds 900 allowed). Consider refactoring.
                        Open

                        #!/usr/bin/env python3
"""Script to manage categories.

Syntax:
                        Severity: Major
                        Found in scripts/category.py - About 1 day to fix

                          File checkimages.py has 1350 lines of code (exceeds 900 allowed). Consider refactoring.
                          Open

                          #!/usr/bin/env python3
"""Script to check recently uploaded files.

This script checks if a file description is present and if there are
other problems in the image's description.
                          Severity: Major
                          Found in scripts/checkimages.py - About 1 day to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            class TestPartiallyQualifiedExplicitLinkDifferentFamilyParser(LinkTestCase):

    """Link tests."""

    family = 'wikipedia'
                            Severity: Major
                            Found in tests/link_tests.py and 2 other locations - About 1 day to fix
                            tests/link_tests.py on lines 525..552
                            tests/link_tests.py on lines 616..643

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 175.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            class TestFullyQualifiedOneSiteFamilyExplicitLinkParser(LinkTestCase):

    """Test links to one site target family."""

    family = 'species'
                            Severity: Major
                            Found in tests/link_tests.py and 2 other locations - About 1 day to fix
                            tests/link_tests.py on lines 311..338
                            tests/link_tests.py on lines 616..643

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 175.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            class TestPartiallyQualifiedImplicitLinkDifferentFamilyParser(LinkTestCase):

    """Test partially qualified links to different family."""

    family = 'wikipedia'
                            Severity: Major
                            Found in tests/link_tests.py and 2 other locations - About 1 day to fix
                            tests/link_tests.py on lines 311..338
                            tests/link_tests.py on lines 525..552

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 175.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            File wikibase_tests.py has 1208 lines of code (exceeds 900 allowed). Consider refactoring.
                            Open

                            #!/usr/bin/env python3
"""Tests for the Wikidata parts of the page module."""
#
# (C) Pywikibot team, 2008-2024
#
                            Severity: Major
                            Found in tests/wikibase_tests.py - About 1 day to fix

                              File create_isbn_edition.py has 1169 lines of code (exceeds 900 allowed). Consider refactoring.
                              Open

                              #!/usr/bin/env python3
r"""Pywikibot client to load ISBN linked data into Wikidata.

Pywikibot script to get ISBN data from a digital library, and create or
amend the related Wikidata item for edition (with the
                              Severity: Major
                              Found in scripts/create_isbn_edition.py - About 1 day to fix

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                class TestFullyQualifiedExplicitLinkSameFamilyParser(LinkTestWikiEn):

    """Link tests."""

    def test_fully_qualified_NS0_code(self):
                                Severity: Major
                                Found in tests/link_tests.py and 3 other locations - About 1 day to fix
                                tests/link_tests.py on lines 290..308
                                tests/link_tests.py on lines 595..613
                                tests/link_tests.py on lines 646..664

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 133.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language