Sign upLogin

wikimedia/wikimedia-fundraising-SmashPig

View on GitHub
Star
Core/DataStores/PaymentsFraudDatabase.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method storeBreakdown has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function storeBreakdown( int $paymentsFraudId, array $breakdown, bool $inserting ): void {
        // TODO: add a unique key on (payments_fraud_id, filter_name) so we can do an
        // upsert with ON DUPLICATE KEY UPDATE rather than selecting first
        $existing = [];
        if ( !$inserting ) {
Severity: Minor
Found in Core/DataStores/PaymentsFraudDatabase.php - About 1 hr to fix

    Function storeBreakdown has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function storeBreakdown( int $paymentsFraudId, array $breakdown, bool $inserting ): void {
        // TODO: add a unique key on (payments_fraud_id, filter_name) so we can do an
        // upsert with ON DUPLICATE KEY UPDATE rather than selecting first
        $existing = [];
        if ( !$inserting ) {
    Severity: Minor
    Found in Core/DataStores/PaymentsFraudDatabase.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method storeMessage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function storeMessage( array $message ) {
        $breakdown = $message['score_breakdown'] ?? null;
        unset( $message['score_breakdown'] );
        if ( $message['risk_score'] > self::MAX_RISK_SCORE ) {
            $message['risk_score'] = self::MAX_RISK_SCORE;
    Severity: Minor
    Found in Core/DataStores/PaymentsFraudDatabase.php - About 1 hr to fix

      Method fetchMessageByGatewayOrderId has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fetchMessageByGatewayOrderId(
        string $gatewayName,
        string $orderId,
        bool $withBreakdown = false
    ): ?array {
      Severity: Minor
      Found in Core/DataStores/PaymentsFraudDatabase.php - About 1 hr to fix

        Function storeMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function storeMessage( array $message ) {
        $breakdown = $message['score_breakdown'] ?? null;
        unset( $message['score_breakdown'] );
        if ( $message['risk_score'] > self::MAX_RISK_SCORE ) {
            $message['risk_score'] = self::MAX_RISK_SCORE;
        Severity: Minor
        Found in Core/DataStores/PaymentsFraudDatabase.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status