wikimedia/wikimedia-fundraising-dash

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            return connection.query( update, updateParams )
                .then( function ( dbResults ) {
                    if ( dbResults[ 0 ].affectedRows !== 1 ) {
                        // Either the instance doesn't exist or it's not ours
                        throw new Error( 'Instance ' + instance.id + ' with owner ' + instance.ownerId + ' not found' );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            return connection.query( update, updateParams )
                .then( function ( dbResults ) {
                    if ( dbResults[ 0 ].affectedRows !== 1 ) {
                        // Either the board doesn't exist or it's not ours
                        throw new Error( 'Board ' + board.id + ' with owner ' + board.ownerId + ' not found' );

• Read up
  Read up

Function loginUser has 51 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    loginUser: function ( user ) {
        var params = [ user.id, user.provider, user.displayName ],
            insertUser = 'INSERT IGNORE INTO dash_user ( oauth_id, oauth_provider, display_name ) VALUES ( ?, ?, ? )',
            getInfo = 'SELECT id, default_board, avatar, title, email from dash_user where oauth_id = ? and oauth_provider = ?',
            insertBoard = 'INSERT INTO dash_board ( display_name, description, owner_id ) VALUES ( ?, \'\', ? );' +

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        persistence.saveBoard( board ).then( function () {
            res.json( { success: true, id: board.id } );
        }, function ( error ) {
            res.json( { error: error } );
        } );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        self.disposables.push( self.includeEndowment.subscribe( function () {
            self.config.includeEndowment = self.includeEndowment();
            self.logStateChange();
            self.reloadData();
        } ) );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        persistence.saveWidgetInstance( instance ).then( function () {
            res.json( { success: true, id: instance.id } );
        }, function ( error ) {
            res.json( { error: error } );
        } );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        self.disposables.push( self.majorDonationCutoff.subscribe( function () {
            self.config.majorDonationCutoff = self.majorDonationCutoff();
            self.logStateChange();
            self.reloadData();
        } ) );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        value: function ( value, ratio, id ) {
                            var display;
                            if ( id === 'Hourly Total' ) {
                                display = numeral( value ).format( '$0,0' );
                            } else {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        value: function ( value, ratio, id ) {
                            var display;
                            if ( id === 'Daily Total' ) {
                                display = numeral( value ).format( '$0,0' );
                            } else {

• Read up
  Read up

Function makeCharts has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        self.makeCharts = function () {
            if ( params.sharedContext.dailyDataArray.length < 2 ) {
                return;
            }
            self.hasData( true );

Function DatePickerViewModel has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function DatePickerViewModel( params ) {
        var self = this;

        self.setupTimepicker = function ( event ) {
            $( '#' + event.target.id ).timepicker( {

Function createQueryString has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        self.createQueryString = function () {
            var qs = self.filterQueryString(),
                ds = '',
                timePresets = [
                    'Last 15 Minutes',

Function renderPercentRangeChart has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        self.renderPercentRangeChart = function () {

            var canvas = $( '#fraudPercentRanges' )[ 0 ],
                ctx = canvas.getContext( '2d' ),
                placeholder = document.createElement( 'canvas' ),

Function Top10ViewModel has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function Top10ViewModel( params ) {

        WidgetBase.call( this, params );

        var self = this;

Function update has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        update: function ( el, valueAccessor, allBindingsAccessor /* , viewModel */ ) {
            var allBindings = allBindingsAccessor(),
                converted,
                textAccessor;

Function getBoard has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getBoard: function ( boardId, userId ) {
        var board,
            connection = getConnection(),
            select = 'SELECT owner_id, display_name, description, is_shared FROM dash_board WHERE id = ? AND ( is_shared OR owner_id = ? )';

Function GenericBoardViewModel has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function GenericBoardViewModel( params ) {

        var self = this,
            timeFormat = 'dddd, MMMM Do YYYY, h:mm:ss a';

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        persistence.loginUser( req.session.passport.user ).then( function () {
            res.redirect( '/' );
        }, function ( error ) {
            res.json( error );
        } );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            persistence.loginUser( req.session.passport.user ).then( function () {
                res.redirect( '/' );
            }, function ( error ) {
                res.json( error );
            } );

• Read up
  Read up

Function saveBoard has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    saveBoard: function ( board ) {
        var connection = getConnection(),
            insert = 'INSERT INTO dash_board ( owner_id, display_name, description, is_shared ) VALUES ( ?, ?, ?, ? )',
            addWidget = 'INSERT INTO dash_widget_instance_board ( instance_id, board_id, widget_position ) SELECT ?, b.id, COALESCE( MAX( widget_position ), 0 ) + 1 FROM dash_board b LEFT JOIN dash_widget_instance_board i ON b.id = i.board_id WHERE b.id = ? AND b.owner_id = ?',
            addWidgetParams = [ board.addWidget, board.id, board.ownerId ],