Sign upLogin

wikimedia/wikimedia-fundraising-tools

View on GitHub
Star
CldrParser/CldrParser.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function parseCLDR has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def parseCLDR(cldr_path):
    """Parse CLDR XML files into currency and locale data
    Returns a set of: (
        cldr date
        {currencyIso: {digits, rounding}},
Severity: Minor
Found in CldrParser/CldrParser.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extractNumericLocale has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def extractNumericLocale(locale, pPattern, nPattern=None):
    """Extract grouping char, decimal char, digit grouping, positive, and negative format strings from a pattern
    pPattern -- the positive pattern
    nPattern -- the negative pattern if given
    """
Severity: Minor
Found in CldrParser/CldrParser.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function outputData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def outputData(data, outfile, className, namespace=None):
    """Generates a PHP data file"""

    skeleton = """<?php %(namespace)s
/**
Severity: Minor
Found in CldrParser/CldrParser.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status