Sign upLogin

wikimedia/wikimedia-fundraising-tools

View on GitHub
Star
audit/payflow/PayflowReports.php

Summary

Maintainability
C
7 hrs
Test Coverage

File PayflowReports.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php error_reporting (E_ALL);

/*
 * Base class for a returned Payflow Report. This class is used by all others to access Payflow report data.
 *
Severity: Minor
Found in audit/payflow/PayflowReports.php - About 3 hrs to fix

    Method runReport has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function runReport() {
        $xml = $this->runReportRequest();
        $request = $this->createRequest( $xml );

        $rc = $this->sendRequest( $request );
    Severity: Minor
    Found in audit/payflow/PayflowReports.php - About 1 hr to fix

      Method parseReportResponse has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function parseReportResponse ( $xml_response ) {
        $statusCode = $xml_response->runReportResponse->statusCode;

        switch ( $statusCode ) {
            case 1: // Created
      Severity: Minor
      Found in audit/payflow/PayflowReports.php - About 1 hr to fix

        Function parseReportResponse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function parseReportResponse ( $xml_response ) {
        $statusCode = $xml_response->runReportResponse->statusCode;

        switch ( $statusCode ) {
            case 1: // Created
        Severity: Minor
        Found in audit/payflow/PayflowReports.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status