Sign upLogin

wikirate/wikirate

View on GitHub
Star

Showing 183 of 231 total issues

Assignment Branch Condition size for expect_answers_to_move is too high. [24/15]
Open

  def expect_answers_to_move target_num
    expect(company.answers.count).to eq(5)
    expect(target.answers.count).to eq(10)
    yield
    expect(company.answers.count).to eq(1) # there is one conflicting answer
Severity: Minor
Found in mod/wikirate_companies/spec/set/type/wikirate_company/merge_spec.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for sub_in_db is too high. [21.12/15]
Open

  def sub_in_db old, new
    Card.search(name: ["match", old]).uniq.each do |card|
      next unless card.simple?
      new_name =
        card.name.gsub(old.capitalize, new.capitalize).gsub(old.downcase, new.downcase)
Severity: Minor
Found in lib/tasks/wikirate.rake by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def card_subject
    Card["Argentina+Country Code"]
  end

  let(:country_code) { card_subject }
Severity: Major
Found in mod/wikirate_companies/spec/set/type_plus_right/region/country_code_spec.rb and 1 other location - About 1 hr to fix
mod/wikirate_companies/spec/set/type_plus_right/region/oc_jurisdiction_key_spec.rb on lines 2..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def card_subject
    Card["Argentina+OpenCorporates Jurisdiction key"]
  end

  let(:oc_key) { card_subject }
Severity: Major
Found in mod/wikirate_companies/spec/set/type_plus_right/region/oc_jurisdiction_key_spec.rb and 1 other location - About 1 hr to fix
mod/wikirate_companies/spec/set/type_plus_right/region/country_code_spec.rb on lines 2..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe "check badges" do
    let(:badge_action) { :check }
    let(:sample_acting_card) { sample_answer.field(:checked_by) }

    def execute_awarded_action count
Severity: Minor
Found in mod/badges/spec/set/type_plus_right/metric_answer/checked_by/award_badges_spec.rb and 1 other location - About 55 mins to fix
mod/badges/spec/set/type_plus_right/metric_answer/discussion/award_badges_spec.rb on lines 4..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe "discuss badges" do
    let(:badge_action) { :discuss }
    let(:sample_acting_card) { sample_answer.field(:discussion) }

    def execute_awarded_action count
Severity: Minor
Found in mod/badges/spec/set/type_plus_right/metric_answer/discussion/award_badges_spec.rb and 1 other location - About 55 mins to fix
mod/badges/spec/set/type_plus_right/metric_answer/checked_by/award_badges_spec.rb on lines 4..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it_behaves_like "cached count", "#{Card::Name[:star_wars_source]}+metric", 4, 1 do
    let :add_one do
      Card["Jedi+Weapons"].create_answers do
        Samsung "1977" => { value: "hand", source: Card[:star_wars_source] }
      end
Severity: Minor
Found in mod/deckorate_research/spec/set/type_plus_right/source/metric_spec.rb and 1 other location - About 40 mins to fix
mod/deckorate_research/spec/set/type_plus_right/source/metric_answer_spec.rb on lines 2..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it_behaves_like "cached count", "#{Card::Name[:star_wars_source]}+answer", 20, 1 do
    let :add_one do
      Card["Jedi+Weapons"].create_answers do
        Samsung "1977" => { value: "hand", source: Card[:star_wars_source] }
      end
Severity: Minor
Found in mod/deckorate_research/spec/set/type_plus_right/source/metric_answer_spec.rb and 1 other location - About 40 mins to fix
mod/deckorate_research/spec/set/type_plus_right/source/metric_spec.rb on lines 2..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe "formula card" do
    let(:wikirating_card) { Card[:wiki_rating] }

    it { is_expected.to be_truthy }
    it "has codename" do
Severity: Minor
Found in mod/deckorate_calculations/spec/set/metric_type/wiki_rating_spec.rb and 1 other location - About 35 mins to fix
mod/deckorate_calculations/spec/set/metric_type/score_basic_properties_spec.rb on lines 12..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe "score card" do
    let(:score_card) { Card[:score] }

    it { is_expected.to be_truthy }
    it "has codename" do
Severity: Minor
Found in mod/deckorate_calculations/spec/set/metric_type/score_basic_properties_spec.rb and 1 other location - About 35 mins to fix
mod/deckorate_calculations/spec/set/metric_type/wiki_rating_spec.rb on lines 23..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  context "when metric is designer assessed." do
    let(:reference_number) { 3 }

    it "does not include community credit in Rich Text." do
      expect_view(:rich_text_attrib).not_to match(/Wikirate's community/)
Severity: Minor
Found in mod/deckorate_attribution/spec/set/type/reference_spec.rb and 2 other locations - About 30 mins to fix
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 22..32
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 50..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  context "when metric is community assessed" do
    let(:reference_number) { 2 }

    it "includes community credit in Rich Text." do
      expect_view(:rich_text_attrib).to match(/Wikirate's community/)
Severity: Minor
Found in mod/deckorate_attribution/spec/set/type/reference_spec.rb and 2 other locations - About 30 mins to fix
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 36..46
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 50..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  context "when it is an answer." do
    let(:reference_number) { 4 }

    it "does include company and year in Rich Text." do
      expect_view(:rich_text_attrib).to match(/(Death Star, 2001)/)
Severity: Minor
Found in mod/deckorate_attribution/spec/set/type/reference_spec.rb and 2 other locations - About 30 mins to fix
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 22..32
mod/deckorate_attribution/spec/set/type/reference_spec.rb on lines 36..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

event :validate_jurisdiction_key, :validate,
      on: :save, changed: :content do
  oc_key = Card.search left: { type: :region },
                       right: :oc_jurisdiction_key,
                       content: card.content
Severity: Minor
Found in mod/wikirate_companies/set/type_plus_right/region/oc_jurisdiction_key.rb and 1 other location - About 25 mins to fix
mod/wikirate_companies/set/type_plus_right/region/country_code.rb on lines 5..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

event :validate_country_code, :validate,
      on: :save, changed: :content do
  country_code = Card.search left: { type: :region },
                             right: :country_code,
                             content: card.content
Severity: Minor
Found in mod/wikirate_companies/set/type_plus_right/region/country_code.rb and 1 other location - About 25 mins to fix
mod/wikirate_companies/set/type_plus_right/region/oc_jurisdiction_key.rb on lines 9..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it_behaves_like "cached count", ["Force", :dataset], 1, 1 do
    let :add_one do
      Card.fetch("Empty Dataset", :wikirate_topic, new: {}).add_item! "Force"
    end
    let :delete_one do
Severity: Minor
Found in mod/deckorate_datasets/spec/set/type_plus_right/wikirate_topic/dataset_spec.rb and 1 other location - About 25 mins to fix
mod/wikirate_companies/spec/set/type_plus_right/wikirate_company/dataset_spec.rb on lines 4..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it_behaves_like "cached count", ["Death Star", :dataset], 1, 1 do
    let :add_one do
      Card.fetch("Empty Dataset", :wikirate_company, new: {}).add_item! "Death Star"
    end
    let :delete_one do
Severity: Minor
Found in mod/wikirate_companies/spec/set/type_plus_right/wikirate_company/dataset_spec.rb and 1 other location - About 25 mins to fix
mod/deckorate_datasets/spec/set/type_plus_right/wikirate_topic/dataset_spec.rb on lines 4..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid parameter lists longer than 5 parameters. [6/5]
Open

    def jmeter_flood name, count: 100, host: "http://staging.wikirate.org", duration: 300,
                     rampup: 10,
                     &block
Severity: Minor
Found in lib/tasks/wikirate/flood.rake by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it "creates rating values" do
      expect(rating_value).to eq("8.0")
      expect(rating_value("Samsung", "2015")).to eq("3.8")
      expect(rating_value("Sony_Corporation")).to eq("1.4")
      expect(rating_answer("Death_Star", "1977")).to be_falsey
Severity: Minor
Found in mod/deckorate_calculations/spec/set/metric_type/wiki_rating_spec.rb and 1 other location - About 20 mins to fix
mod/deckorate_calculations/spec/set/metric_type/score_spec.rb on lines 38..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it "creates score values" do
        expect(score_value).to eq("10")
        expect(score_value("Samsung", "2015")).to eq("4")
        expect(score_value("Sony_Corporation")).to eq("4")
        expect(score_answer("Death_Star", "1977")).to be_falsey
Severity: Minor
Found in mod/deckorate_calculations/spec/set/metric_type/score_spec.rb and 1 other location - About 20 mins to fix
mod/deckorate_calculations/spec/set/metric_type/wiki_rating_spec.rb on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language