Sign upLogin

williamfzc/fitch

View on GitHub
Star

Showing 3 of 3 total issues

Function _find_target has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _find_target(
        self, target_path: typing.Union[list, tuple], save_pic: str = None
    ) -> typing.Union[list, None]:
        """ base API, should not be directly used I think. find target pic in screen, and get widget list (or None) """
        p = self.screen_shot_to_object()
Severity: Minor
Found in fitch/device.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function swipe has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def swipe(
Severity: Minor
Found in fitch/player.py - About 45 mins to fix

    Function swipe has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def swipe(
    Severity: Minor
    Found in fitch/player.py - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language