Sign upLogin

winston0410/camouflage

View on GitHub
Star
benchmarks/cacheStyle/rendererCache.ts

Summary

Maintainability
D
1 day
Test Coverage

Function addOn has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

const addOn = function (renderer) {
    // Setting the cache outside this function may result in more persistant but unexpected behaviors
    renderer.cache = {}
    // This can should be used for validating against 1) Rules generated with virtua()/atomic() 2) Rules received from hydration()
Severity: Minor
Found in benchmarks/cacheStyle/rendererCache.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addOn has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const addOn = function (renderer) {
    // Setting the cache outside this function may result in more persistant but unexpected behaviors
    renderer.cache = {}
    // This can should be used for validating against 1) Rules generated with virtua()/atomic() 2) Rules received from hydration()
Severity: Minor
Found in benchmarks/cacheStyle/rendererCache.ts - About 1 hr to fix

    Function objectToClassNames has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const objectToClassNames = (decls, selector = '', atRule = '') => {
        let classNames = ''
        for (const prop in decls) {
            const value = decls[prop]
            const id = `${atRule}${selector}${prop}${value}`
    Severity: Minor
    Found in benchmarks/cacheStyle/rendererCache.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (Array.isArray(value)) {
                classNames += renderer.cache[id] = ` ${renderer.atomic(
                    cssifyArray(prop, value)
                )}`
            } else if (safeIsObj(value)) {
      Severity: Major
      Found in benchmarks/cacheStyle/rendererCache.ts and 1 other location - About 7 hrs to fix
      src/addon/virtual.ts on lines 35..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 187.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          renderer.atomic = function (rawDecl, selector = '', atRule = '') {
        const className = assembleClassName(renderer)

        const rule = assembleRule(`.${className}${selector}`, rawDecl)
      Severity: Major
      Found in benchmarks/cacheStyle/rendererCache.ts and 1 other location - About 2 hrs to fix
      benchmarks/cacheStyle/variableCache.ts on lines 53..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status