controllers/buildtools/jenkins.go
Method Jenkins.AddJenkinsBuilds
has 99 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
if db == nil {
return errors.New("Wrong database handler!")
}
Method Jenkins.AddJenkinsBuilds
has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
Open
func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
if db == nil {
return errors.New("Wrong database handler!")
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Jenkins.AddJenkinsBuilds
has 7 return statements (exceeds 4 allowed). Open
Open
func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
if db == nil {
return errors.New("Wrong database handler!")
}
error strings should not be capitalized or end with punctuation or a newline Open
Open
return errors.New("Wrong database handler!")
- Exclude checks