wisedog/ladybug

View on GitHub
controllers/buildtools/jenkins.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Jenkins.AddJenkinsBuilds has 99 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
    if db == nil {
        return errors.New("Wrong database handler!")
    }

Severity: Major
Found in controllers/buildtools/jenkins.go - About 2 hrs to fix

    Method Jenkins.AddJenkinsBuilds has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
        if db == nil {
            return errors.New("Wrong database handler!")
        }
    
    
    Severity: Minor
    Found in controllers/buildtools/jenkins.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Jenkins.AddJenkinsBuilds has 7 return statements (exceeds 4 allowed).
    Open

    func (j Jenkins) AddJenkinsBuilds(url string, projectID int, db *gorm.DB) error {
        if db == nil {
            return errors.New("Wrong database handler!")
        }
    
    
    Severity: Major
    Found in controllers/buildtools/jenkins.go - About 45 mins to fix

      error strings should not be capitalized or end with punctuation or a newline
      Open

              return errors.New("Wrong database handler!")
      Severity: Minor
      Found in controllers/buildtools/jenkins.go by golint

      There are no issues that match your filters.

      Category
      Status