Sign upLogin

wisedog/ladybug

View on GitHub
Star
controllers/requirements.go

Summary

Maintainability
C
1 day
Test Coverage

Function addEditRequirement has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func addEditRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isEdit bool) error {
    var errorMap map[string]string
    var req models.Requirement

    session, e := c.Store.Get(r, "ladybug")
Severity: Minor
Found in controllers/requirements.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addEditRequirement has 71 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func addEditRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isEdit bool) error {
    var errorMap map[string]string
    var req models.Requirement

    session, e := c.Store.Get(r, "ladybug")
Severity: Minor
Found in controllers/requirements.go - About 1 hr to fix

    Function saveUpdateRequirement has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func saveUpdateRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isUpdate bool) error {
    var req models.Requirement
    vars := mux.Vars(r)
    idStr := vars["id"]
    Severity: Minor
    Found in controllers/requirements.go - About 1 hr to fix

      Function saveUpdateRequirement has 10 return statements (exceeds 4 allowed).
      Open

      func saveUpdateRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isUpdate bool) error {
    var req models.Requirement
    vars := mux.Vars(r)
    idStr := vars["id"]
      Severity: Major
      Found in controllers/requirements.go - About 1 hr to fix

        Function saveUpdateRequirement has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
        Open

        func saveUpdateRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isUpdate bool) error {
    var req models.Requirement
    vars := mux.Vars(r)
    idStr := vars["id"]
        Severity: Minor
        Found in controllers/requirements.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function UnlinkTestcaseRelation has 6 return statements (exceeds 4 allowed).
        Open

        func UnlinkTestcaseRelation(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request) error {
    // get requirement, testcase ID from post
    if err := r.ParseForm(); err != nil {
        log.Error("Requirement", "type", "app", "msg ", err.Error())
        return RenderJSONWithStatus(w, Resp{Msg: "Parse form is not valid"}, http.StatusBadRequest)
        Severity: Major
        Found in controllers/requirements.go - About 40 mins to fix

          Function addEditRequirement has 6 return statements (exceeds 4 allowed).
          Open

          func addEditRequirement(c *interfacer.AppContext, w http.ResponseWriter, r *http.Request, isEdit bool) error {
    var errorMap map[string]string
    var req models.Requirement

    session, e := c.Store.Get(r, "ladybug")
          Severity: Major
          Found in controllers/requirements.go - About 40 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                for _, n := range sections {
        var nodeType string
        var parent string
        if n.RootNode == true {
            nodeType = "root"
            Severity: Major
            Found in controllers/requirements.go and 2 other locations - About 1 hr to fix
            controllers/testdesign.go on lines 45..57
            controllers/testplans.go on lines 54..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
            Open

                    } else {
            Severity: Minor
            Found in controllers/requirements.go by golint

            There are no issues that match your filters.

            Category
            Status