Sign upLogin

wkdhkr/dedupper

View on GitHub
Star

Showing 303 of 303 total issues

Avoid too many return statements within this function.
Open

      return this.rl.logResult(fileInfo, [
        this.al.fixAction(!this.config.instantDelete, TYPE_DELETE),
        null,
        deleteReason
      ]);
Severity: Major
Found in src/services/judgment/JudgmentService.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return this.rl.logResult(fileInfo, [
          this.config.deepLearningConfig.instantDelete
            ? TYPE_DELETE
            : TYPE_HOLD,
          null,
    Severity: Major
    Found in src/services/judgment/JudgmentService.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return this.pl.handleNameHit(fileInfo, storedFileInfoByNames);
      Severity: Major
      Found in src/services/judgment/JudgmentService.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              expect(await subject.readInfo()).toMatchObject({
        damaged: false,
        height: 0,
        ratio: 0,
        width: 0
        Severity: Minor
        Found in __tests__/services/fs/contents/ContentsService.test.js and 1 other location - About 30 mins to fix
        __tests__/services/fs/contents/ContentsService.test.js on lines 65..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              } else if ((this.config.dbFill || 0) > 0) {
        const dfs = new DbFillService(this.config);
        await dfs.run(this.config.dbFill || 1, 1000);
      } else if (this.config.acdSync) {
        const ass = new ACDSyncService(this.config);
        Severity: Minor
        Found in src/App.js and 1 other location - About 30 mins to fix
        src/App.js on lines 112..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              expect(await subject.readInfo()).toMatchObject({
        damaged: true,
        height: 0,
        ratio: 0,
        width: 0
        Severity: Minor
        Found in __tests__/services/fs/contents/ContentsService.test.js and 1 other location - About 30 mins to fix
        __tests__/services/fs/contents/ContentsService.test.js on lines 80..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              fileInfo.nsfwJs.results.forEach(({ className, probability }) => {
        if (
          [CLASS_NAME_PORN, CLASS_NAME_SEXY, CLASS_NAME_HENTAI].includes(
            className
          )
        Severity: Minor
        Found in src/defaultConfig.js and 1 other location - About 30 mins to fix
        src/defaultConfig.js on lines 398..406

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            results.forEach(({ className, probability }) => {
      if (
        [CLASS_NAME_PORN, CLASS_NAME_SEXY, CLASS_NAME_HENTAI].includes(
          className
        )
        Severity: Minor
        Found in src/defaultConfig.js and 1 other location - About 30 mins to fix
        src/defaultConfig.js on lines 311..319

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              } else if (this.config.acdSync) {
        const ass = new ACDSyncService(this.config);
        await ass.run(this.config.acdSync || 1, 1000);
      } else if (this.config.server) {
        const s = new Server(this.config);
        Severity: Minor
        Found in src/App.js and 1 other location - About 30 mins to fix
        src/App.js on lines 109..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function default has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function(config: Config): any {
  const router = express.Router();
  const log = log4js.getLogger("sqliteAll");
  const ds = new DbService(config);
  const tds = new TagDbService(config);
        Severity: Minor
        Found in src/servers/routes/sqliteAllRoute.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function detectFileTypeReasonAndAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          async detectFileTypeReasonAndAction(
    fileInfo: FileInfo
  ): Promise<?[ReasonType, ActionType]> {
    if (fileInfo.type === TYPE_UNKNOWN) {
      return [TYPE_UNKNOWN_FILE_TYPE, TYPE_HOLD];
        Severity: Minor
        Found in src/services/judgment/TypeLogic.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        FIXME found
        Open

                  db.run("COMMIT"); // FIXME: danger
        Severity: Minor
        Found in src/helpers/DbHelper.js by fixme

        XXX found
        Open

           * XXX: pHash library cannot process multibyte file path.
        Severity: Minor
        Found in src/helpers/FileSystemHelper.js by fixme

        XXX found
        Open

                    // XXX: depends ffprobe message.
        Severity: Minor
        Found in src/services/fs/contents/FFMpegService.js by fixme

        TODO found
        Open

              // TODO: support multi process
        Severity: Minor
        Found in src/helpers/DbHelper.js by fixme

        TODO found
        Open

                // TODO: version check?
        Severity: Minor
        Found in src/services/db/DbRepairService.js by fixme

        XXX found
        Open

           * XXX: pHash library cannot process multibyte file path.
        Severity: Minor
        Found in src/services/fs/contents/PHashService.js by fixme

        XXX found
        Open

           * XXX: Do not use this method! The same hash is returned between different files.
        Severity: Minor
        Found in src/services/fs/contents/FFProbeService.js by fixme

        TODO found
        Open

        // TODO: type
        Severity: Minor
        Found in src/services/deepLearning/faceApi/commons/faceDetection.js by fixme

        XXX found
        Open

                    // XXX: depends ffprobe message.
        Severity: Minor
        Found in src/services/fs/contents/FFProbeService.js by fixme
        Severity
        Category
        Status
        Source
        Language