Sign upLogin

wmakeev/moysklad

View on GitHub
Star

Showing 537 of 537 total issues

Avoid deeply nested control flow statements.
Open

      for (p in args) {
        if (args.hasOwnProperty(p)) { argsKeys[i++] = p }
      }
Severity: Major
Found in bundle/umd/moysklad.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            if (fail) break
    Severity: Major
    Found in bundle/umd/moysklad.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              if (ensured) {
          parsedArgs[argName] = args[argsKeys[argIndex]]
          argIndex++
        }
      Severity: Major
      Found in bundle/umd/moysklad.js - About 45 mins to fix

        Function getEnvVar has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function getEnvVar(key, defaultValue) {
  if (typeof process !== 'undefined' && process.env && process.env[key]) {
    return process.env[key]
  } else if (typeof window !== 'undefined' && window[key]) {
    return window[key]
        Severity: Minor
        Found in src/getEnvVar.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parseQueryString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function parseQueryString(queryString) {
  if (queryString == null || queryString === '') {
    return undefined
  }
  queryString = queryString.trim()
        Severity: Minor
        Found in src/tools/parseQueryString.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Object.keys(selectors).forEach(key => {
  selectors[key].name = `$${key}`
})
        Severity: Minor
        Found in src/tools/buildFilter.js and 1 other location - About 40 mins to fix
        bundle/umd/moysklad.js on lines 1284..1286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Object.keys(selectors).forEach(key => {
  selectors[key].name = `$${key}`
})
        Severity: Minor
        Found in bundle/umd/moysklad.js and 1 other location - About 40 mins to fix
        src/tools/buildFilter.js on lines 46..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function ensure has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function ensure (matchers, argName, argType, value, check) {
        Severity: Minor
        Found in bundle/umd/moysklad.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const createValueSelector = selector => (path, value) => {
  if (!isSimpleValue(value)) {
    throw new MoyskladError(
      'значение должно быть строкой, числом, датой или null'
    )
          Severity: Minor
          Found in bundle/umd/moysklad.js and 1 other location - About 35 mins to fix
          src/tools/buildFilter.js on lines 8..15

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const createValueSelector = selector => (path, value) => {
  if (!isSimpleValue(value)) {
    throw new MoyskladError(
      'значение должно быть строкой, числом, датой или null'
    )
          Severity: Minor
          Found in src/tools/buildFilter.js and 1 other location - About 35 mins to fix
          bundle/umd/moysklad.js on lines 1246..1253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function buildUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function buildUrl(...args) {
  // eslint-disable-next-line prefer-const
  let { url, path, query } = have.strict(args, [
    { url: 'url', query: 'opt Object' },
    { path: 'str or str arr', query: 'opt Object' },
          Severity: Minor
          Found in src/methods/buildUrl.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return true
          Severity: Major
          Found in bundle/umd/moysklad.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return result
            Severity: Major
            Found in bundle/umd/moysklad.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return result
              Severity: Major
              Found in src/methods/fetchUrl.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false
                Severity: Major
                Found in bundle/umd/moysklad.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return null
                  Severity: Major
                  Found in src/getResponseError.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      return null
                    Severity: Major
                    Found in bundle/umd/moysklad.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return true
                      Severity: Major
                      Found in bundle/umd/moysklad.js - About 30 mins to fix

                        Replace ·error.error·+·(error.moreInfo·?··(${error.moreInfo})·:·'') with ⏎······error.error·+·(error.moreInfo·?··(${error.moreInfo})·:·"");
                        Open

                            const message = error.error + (error.moreInfo ? ` (${error.moreInfo})` : '')
                        Severity: Minor
                        Found in src/errors.js by eslint

                        For more information visit Source: http://eslint.org/docs/rules/

                        Replace '.min'·:·'' with ".min"·:·""
                        Open

                            filename: `./bundle/umd/moysklad${minimize ? '.min' : ''}.js`,
                        Severity: Minor
                        Found in webpack.config.js by eslint

                        For more information visit Source: http://eslint.org/docs/rules/

                        Severity
                        Category
                        Status
                        Source
                        Language