woese/guara-crm

View on GitHub

Showing 101 of 101 total issues

Method format has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def format(str, section)
        @prefix = ''
        @suffix = ''

        mods = section[:modifiers]
Severity: Major
Found in lib/active_migration/converters/rtf_to_html.rb - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                html += '<dt class="ui_tpicker_millisec_label" id="ui_tpicker_millisec_label_' + dp_id + '"' +
                        ((o.showMillisec) ? '' : noDisplay) + '>' + o.millisecText + '</dt>'+
                        '<dd class="ui_tpicker_millisec"><div id="ui_tpicker_millisec_' + dp_id + '"'+
                                ((o.showMillisec) ? '' : noDisplay) + '></div>';
    Severity: Major
    Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 2 hrs to fix
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 392..395
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 410..413

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                html += '<dt class="ui_tpicker_second_label" id="ui_tpicker_second_label_' + dp_id + '"' +
                        ((o.showSecond) ? '' : noDisplay) + '>' + o.secondText + '</dt>'+
                        '<dd class="ui_tpicker_second"><div id="ui_tpicker_second_' + dp_id + '"'+
                                ((o.showSecond) ? '' : noDisplay) + '></div>';
    Severity: Major
    Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 2 hrs to fix
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 392..395
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 428..431

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                html += '<dt class="ui_tpicker_minute_label" id="ui_tpicker_minute_label_' + dp_id + '"' +
                        ((o.showMinute) ? '' : noDisplay) + '>' + o.minuteText + '</dt>'+
                        '<dd class="ui_tpicker_minute"><div id="ui_tpicker_minute_' + dp_id + '"' +
                                ((o.showMinute) ? '' : noDisplay) + '></div>';
    Severity: Major
    Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 2 hrs to fix
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 410..413
    app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 428..431

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function elPrepare has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                function elPrepare() {
                    name = element.attr("name");
                    if (options.bricket) {
                        if (typeof(name) != 'undefined' && name.indexOf("[]") == -1) {
                            name = name + "[]"
    Severity: Minor
    Found in app/assets/javascripts/fcbk.js - About 1 hr to fix

      Function _optionDatepicker has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      $.datepicker._optionDatepicker = function(target, name, value) {
          var inst = this._getInst(target),
              tp_inst = this._get(inst, 'timepicker');
          if (tp_inst) {
              var min,max,onselect;
      Severity: Minor
      Found in app/assets/javascripts/jquery-ui-timepicker-addon.js - About 1 hr to fix

        Function addMembers has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function addMembers(etext, data) {
                        feed.html('');
                        if (!options.cache && data != null) {
                            cache.clear()
                        }
        Severity: Minor
        Found in app/assets/javascripts/fcbk.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(tp_inst._defaults.minDateTime !== undefined && tp_inst._defaults.minDateTime instanceof Date)
                      tp_inst._defaults.minDate = new Date(tp_inst._defaults.minDateTime.getTime());
          Severity: Major
          Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 1 hr to fix
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 206..207
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 208..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if (max){ //if max was set
                      if(max==0)
                          max=new Date();
                      else
                          max= new Date(max);
          Severity: Major
          Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 1287..1304

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(tp_inst._defaults.maxDate !== undefined && tp_inst._defaults.maxDate instanceof Date)
                      tp_inst._defaults.maxDateTime = new Date(tp_inst._defaults.maxDate.getTime());
          Severity: Major
          Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 1 hr to fix
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 204..205
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 208..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if(min){ //if min was set
                      if(min==0)
                          min=new Date();
                      else
                          min= new Date(min);
          Severity: Major
          Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 1295..1304

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if(tp_inst._defaults.maxDateTime !== undefined && tp_inst._defaults.maxDateTime instanceof Date)
                      tp_inst._defaults.maxDate = new Date(tp_inst._defaults.maxDateTime.getTime());
          Severity: Major
          Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 2 other locations - About 1 hr to fix
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 204..205
          app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 206..207

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function bindEvents has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      function bindEvents() {
                          var maininput = $("#" + elemid + "_annoninput").children(".maininput");
                          bindFeedEvent();
                          feed.children("li").unbind("mousedown").mousedown(function() {
                              var option = $(this);
          Severity: Minor
          Found in app/assets/javascripts/fcbk.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(this.hourMinOriginal === null || this.minuteMinOriginal === null || this.secondMinOriginal === null || this.millisecMinOriginal === null){
                            this.hourMinOriginal = o.hourMin;
                            this.minuteMinOriginal = o.minuteMin;
                            this.secondMinOriginal = o.secondMin;
                            this.millisecMinOriginal = o.millisecMin;
            Severity: Major
            Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 720..725

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(this.hourMaxOriginal === null || this.minuteMaxOriginal === null || this.secondMaxOriginal === null){
                            this.hourMaxOriginal = o.hourMax;
                            this.minuteMaxOriginal = o.minuteMax;
                            this.secondMaxOriginal = o.secondMax;
                            this.millisecMaxOriginal = o.millisecMax;
            Severity: Major
            Found in app/assets/javascripts/jquery-ui-timepicker-addon.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/jquery-ui-timepicker-addon.js on lines 680..685

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function formatTime has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            $.datepicker.formatTime = function(format, time, options) {
                options = options || {};
                options = $.extend($.timepicker._defaults, options);
                time = $.extend({hour:0, minute:0, second:0, millisec:0, timezone:'+0000'}, time);
                
            Severity: Minor
            Found in app/assets/javascripts/jquery-ui-timepicker-addon.js - About 1 hr to fix

              Function _onTimeChange has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  _onTimeChange: function() {
                      var hour   = (this.hour_slider) ? this.hour_slider.slider('value') : false,
                          minute = (this.minute_slider) ? this.minute_slider.slider('value') : false,
                          second = (this.second_slider) ? this.second_slider.slider('value') : false,
                          millisec = (this.millisec_slider) ? this.millisec_slider.slider('value') : false,
              Severity: Minor
              Found in app/assets/javascripts/jquery-ui-timepicker-addon.js - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                        if ((hour < defaults.hourMin || hour > defaults.hourMax) || (minute < defaults.minuteMin || minute > defaults.minuteMax) || (second < defaults.secondMin || second > defaults.secondMax) || (millisec < defaults.millisecMin || millisec > defaults.millisecMax)) {
                            hour = defaults.hourMin;
                            minute = defaults.minuteMin;
                            second = defaults.secondMin;
                            millisec = defaults.millisecMin;
                Severity: Critical
                Found in app/assets/javascripts/jquery-ui-timepicker-addon.js - About 1 hr to fix

                  Function createFCBK has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              function createFCBK() {
                                  holder = $('<ul class="holder"></ul>').width(options.width);
                                  if (options.attachto) {
                                      if (typeof(options.attachto) == "object") {
                                          options.attachto.append(holder)
                  Severity: Minor
                  Found in app/assets/javascripts/fcbk.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      def create
                        @task_type = TaskType.new(params[:task_type])
                    
                        respond_to do |format|
                          if @task_type.save
                    Severity: Major
                    Found in app/controllers/task_types_controller.rb and 1 other location - About 1 hr to fix
                    app/controllers/system_task_status_controller.rb on lines 43..52

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language