Sign upLogin

wol-soft/php-json-schema-model-generator

View on GitHub
Star
src/Model/Schema.php

Summary

Maintainability
A
3 hrs
Test Coverage
A
95%

Schema has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class Schema
{
    use JsonSchemaTrait;

    /** @var string */
Severity: Minor
Found in src/Model/Schema.php - About 2 hrs to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $classPath,
        string $className,
        JsonSchema $schema,
        ?SchemaDefinitionDictionary $dictionary = null,
        bool $initialClass = false,
    Severity: Minor
    Found in src/Model/Schema.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->properties;
      Severity: Major
      Found in src/Model/Schema.php - About 30 mins to fix

        The method __construct has a boolean flag argument $initialClass, which is a certain sign of a Single Responsibility Principle violation.
        Open

                bool $initialClass = false,
        Severity: Minor
        Found in src/Model/Schema.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method addProperty uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            // TODO tests:
            // testConditionalObjectProperty
            // testInvalidConditionalObjectPropertyThrowsAnException
            // testInvalidValuesForMultipleValuesInCompositionThrowsAnException
        Severity: Minor
        Found in src/Model/Schema.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        syntax error, unexpected ')', expecting variable (T_VARIABLE)
        Open

            ) {
        Severity: Critical
        Found in src/Model/Schema.php by phan

        Arguments with default values must be at the end of the argument list
        Open

                bool $initialClass = false,
        Severity: Minor
        Found in src/Model/Schema.php by phpcodesniffer

        Line indented incorrectly; expected 8 spaces, found 12
        Open

                    },
        Severity: Minor
        Found in src/Model/Schema.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 16
        Open

                        if ($propertyHasSchemaDependencyValidator === $comparedPropertyHasSchemaDependencyValidator) {
        Severity: Minor
        Found in src/Model/Schema.php by phpcodesniffer

        Line indented incorrectly; expected 12 spaces, found 16
        Open

                        }
        Severity: Minor
        Found in src/Model/Schema.php by phpcodesniffer

        Line indented incorrectly; expected 8 spaces, found 12
        Open

                    static function (
        Severity: Minor
        Found in src/Model/Schema.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status