wol-soft/php-json-schema-model-generator

View on GitHub
src/Model/SchemaDefinition/SchemaDefinition.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
92%

Method resolveReference has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function resolveReference(
        string $propertyName,
        array $path,
        PropertyMetaDataCollection $propertyMetaDataCollection,
    ): PropertyInterface {
Severity: Minor
Found in src/Model/SchemaDefinition/SchemaDefinition.php - About 1 hr to fix

    Function resolveReference has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function resolveReference(
            string $propertyName,
            array $path,
            PropertyMetaDataCollection $propertyMetaDataCollection,
        ): PropertyInterface {
    Severity: Minor
    Found in src/Model/SchemaDefinition/SchemaDefinition.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class SchemaDefinition has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class SchemaDefinition
    {
        /** @var JsonSchema */
        protected $source;
        /** @var SchemaProcessor */

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    syntax error, unexpected ')', expecting variable (T_VARIABLE)
    Open

        ): PropertyInterface {

    There are no issues that match your filters.

    Category
    Status