Sign upLogin

wol-soft/php-json-schema-model-generator

View on GitHub
Star
src/PropertyProcessor/ComposedValue/IfProcessor.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
96%

Method generateValidators has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function generateValidators(PropertyInterface $property, JsonSchema $propertySchema): void
    {
        $json = $propertySchema->getJson()['propertySchema']->getJson();

        if (!isset($json['then']) && !isset($json['else'])) {
Severity: Major
Found in src/PropertyProcessor/ComposedValue/IfProcessor.php - About 2 hrs to fix

    Function generateValidators has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function generateValidators(PropertyInterface $property, JsonSchema $propertySchema): void
    {
        $json = $propertySchema->getJson()['propertySchema']->getJson();

        if (!isset($json['then']) && !isset($json['else'])) {
    Severity: Minor
    Found in src/PropertyProcessor/ComposedValue/IfProcessor.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    syntax error, unexpected ')'
    Open

                    )
    Severity: Critical
    Found in src/PropertyProcessor/ComposedValue/IfProcessor.php by phan

    Expected 0 spaces before closing bracket; newline found
    Open

                    $compositionProperty->filterValidators(static fn(Validator $validator): bool =>
    Severity: Minor
    Found in src/PropertyProcessor/ComposedValue/IfProcessor.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status