wol-soft/php-json-schema-model-generator

View on GitHub
src/PropertyProcessor/Decorator/TypeHint/ArrayTypeHintDecorator.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

The method decorate has a boolean flag argument $outputType, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function decorate(string $input, bool $outputType = false): string

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

syntax error, unexpected ')'
Open

            )

Line exceeds 120 characters; contains 142 characters
Open

        // TODO: provide better type hints. Currently provides e.g. "string|array[]" instead of "string|string[]" for a recursive string array

Line indented incorrectly; expected 8 spaces, found 16
Open

                static function (string $typeHint): string {

Line indented incorrectly; expected 8 spaces, found 16
Open

                },

There are no issues that match your filters.

Category
Status