Sign upLogin

wol-soft/php-json-schema-model-generator

View on GitHub
Star
src/PropertyProcessor/Property/MultiTypeProcessor.php

Summary

Maintainability
B
4 hrs
Test Coverage
A
98%

Method process has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(string $propertyName, JsonSchema $propertySchema): PropertyInterface
    {
        $property = parent::process($propertyName, $propertySchema);

        $property->onResolve(function () use ($property, $propertyName, $propertySchema): void {
Severity: Minor
Found in src/PropertyProcessor/Property/MultiTypeProcessor.php - About 1 hr to fix

    Method processSubProperties has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function processSubProperties(
        string $propertyName,
        JsonSchema $propertySchema,
        PropertyInterface $property,
    ): array {
    Severity: Minor
    Found in src/PropertyProcessor/Property/MultiTypeProcessor.php - About 1 hr to fix

      Function processSubProperties has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function processSubProperties(
        string $propertyName,
        JsonSchema $propertySchema,
        PropertyInterface $property,
    ): array {
      Severity: Minor
      Found in src/PropertyProcessor/Property/MultiTypeProcessor.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              PropertyProcessorFactory $propertyProcessorFactory,
        array $types,
        PropertyMetaDataCollection $propertyMetaDataCollection,
        SchemaProcessor $schemaProcessor,
        Schema $schema,
      Severity: Minor
      Found in src/PropertyProcessor/Property/MultiTypeProcessor.php - About 35 mins to fix

        Function transferValidators has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function transferValidators(PropertyInterface $source, PropertyInterface $destination)
    {
        foreach ($source->getValidators() as $validatorContainer) {
            $validator = $validatorContainer->getValidator();
        Severity: Minor
        Found in src/PropertyProcessor/Property/MultiTypeProcessor.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The class MultiTypeProcessor has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
        Open

        class MultiTypeProcessor extends AbstractValueProcessor
{
    /** @var PropertyProcessorInterface[] */
    protected $propertyProcessors = [];
    /** @var string[] */
        Severity: Minor
        Found in src/PropertyProcessor/Property/MultiTypeProcessor.php by phpmd

        CouplingBetweenObjects

        Since: 1.1.0

        A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

        Example

        class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

        Source https://phpmd.org/rules/design.html#couplingbetweenobjects

        syntax error, unexpected ')', expecting variable (T_VARIABLE)
        Open

            ) {
        Severity: Critical
        Found in src/PropertyProcessor/Property/MultiTypeProcessor.php by phan

        Line indented incorrectly; expected 24 spaces, found 36
        Open

                                            static function (PropertyInterface $subProperty): string {
        Severity: Minor
        Found in src/PropertyProcessor/Property/MultiTypeProcessor.php by phpcodesniffer

        Line indented incorrectly; expected 24 spaces, found 36
        Open

                                            },
        Severity: Minor
        Found in src/PropertyProcessor/Property/MultiTypeProcessor.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status