wol-soft/php-json-schema-model-generator

View on GitHub
src/SchemaProcessor/Hook/SchemaHookResolver.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

The method resolveSetterBeforeValidationHook has a boolean flag argument $batchUpdate, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function resolveSetterBeforeValidationHook(PropertyInterface $property, bool $batchUpdate = false): string

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method resolveSetterAfterValidationHook has a boolean flag argument $batchUpdate, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function resolveSetterAfterValidationHook(PropertyInterface $property, bool $batchUpdate = false): string

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

syntax error, unexpected 'private' (T_PRIVATE), expecting variable (T_VARIABLE)
Open

    public function __construct(private Schema $schema) {}

Only one argument is allowed per line in a multi-line function call
Open

            static fn(SchemaHookInterface $hook): bool => is_a($hook, $filterHook),

Closing brace must be on a line by itself
Open

    public function __construct(private Schema $schema) {}

Line indented incorrectly; expected 8 spaces, found 12
Open

            static fn(SchemaHookInterface $hook): bool => is_a($hook, $filterHook),

Opening brace should be on a new line
Open

    public function __construct(private Schema $schema) {}

There are no issues that match your filters.

Category
Status