Method addUpdateAdditionalProperties has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function addUpdateAdditionalProperties(Schema $schema): void
{
$schema->addBaseValidator(
new class ($schema) extends PropertyTemplateValidator {
public function __construct(Schema $schema)Function addAdditionalPropertiesCollectionProperty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function addAdditionalPropertiesCollectionProperty(Schema $schema): void
{
$validationProperty = null;
foreach ($schema->getBaseValidators() as $validator) {
if (is_a($validator, AdditionalPropertiesValidator::class)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused parameters such as '$generatorConfiguration'. Open
public function process(Schema $schema, GeneratorConfiguration $generatorConfiguration): void- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
syntax error, unexpected ')' Open
))- Exclude checks
Avoid using static access to class '\PHPModelGenerator\Utils\RenderHelper' in method 'addUpdateAdditionalProperties'. Open
'additionalProperties' => RenderHelper::varExportArray(
array_keys($schema->getJsonSchema()->getJson()['properties'] ?? []),
),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\PHPModelGenerator\Utils\RenderHelper' in method 'addUpdateAdditionalProperties'. Open
? RenderHelper::varExportArray($patternProperties)- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}