src/SchemaProcessor/PostProcessor/Internal/ExtendObjectPropertiesMatchingPatternPropertiesPostProcessor.php
Function transferPatternPropertiesFilterToProperty has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function transferPatternPropertiesFilterToProperty(
Schema $schema,
GeneratorConfiguration $generatorConfiguration,
): void {
$patternPropertiesValidators = array_filter(- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method transferPatternPropertiesFilterToProperty has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function transferPatternPropertiesFilterToProperty(
Schema $schema,
GeneratorConfiguration $generatorConfiguration,
): void {
$patternPropertiesValidators = array_filter(Method process has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function process(Schema $schema, GeneratorConfiguration $generatorConfiguration): void
{
$this->transferPatternPropertiesFilterToProperty($schema, $generatorConfiguration);
$schema->addSchemaHook(The method transferPatternPropertiesFilterToProperty() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
Open
protected function transferPatternPropertiesFilterToProperty(
Schema $schema,
GeneratorConfiguration $generatorConfiguration,
): void {
$patternPropertiesValidators = array_filter(- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method process has a boolean flag argument $batchUpdate, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function getCode(PropertyInterface $property, bool $batchUpdate = false): string- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
syntax error, unexpected ')' Open
Open
);- Exclude checks
Avoid excessively long class names like ExtendObjectPropertiesMatchingPatternPropertiesPostProcessor. Keep class name length under 40. Open
Open
class ExtendObjectPropertiesMatchingPatternPropertiesPostProcessor extends PostProcessor
{
/**
* @param Schema $schema
* @param GeneratorConfiguration $generatorConfiguration- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Space found after opening bracket of FOREACH loop Open
Open
foreach (- Exclude checks
Space found before closing bracket of FOREACH loop Open
Open
foreach (- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
Open
'Applying multiple transforming filters for property %s is not supported in file %s',- Exclude checks
Expected 0 spaces after opening bracket; newline found Open
Open
foreach (- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
Open
});- Exclude checks
Line indented incorrectly; expected 12 spaces, found 20 Open
Open
static function (Validator $validator): bool {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
Open
static function (PropertyValidatorInterface $validator): bool {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 20 Open
Open
},- Exclude checks
Multi-line function call not indented correctly; expected 20 spaces but found 24 Open
Open
$property->getName(),- Exclude checks
Multi-line function call not indented correctly; expected 8 spaces but found 12 Open
Open
});- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
Open
return sprintf('- Exclude checks
Line indented incorrectly; expected 8 spaces, found 12 Open
Open
});- Exclude checks
Multi-line function call not indented correctly; expected 20 spaces but found 24 Open
Open
'/' . addcslashes($patternPropertiesValidator->getPattern(), '/') . '/',- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
Open
)- Exclude checks