Sign upLogin

wol-soft/php-json-schema-model-generator

View on GitHub
Star
src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Method process has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(Schema $schema, GeneratorConfiguration $generatorConfiguration): void
    {
        $json = $schema->getJsonSchema()->getJson();

        if (!isset($json['patternProperties'])) {
Severity: Minor
Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php - About 1 hr to fix

    Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function process(Schema $schema, GeneratorConfiguration $generatorConfiguration): void
    {
        $json = $schema->getJsonSchema()->getJson();

        if (!isset($json['patternProperties'])) {
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused parameters such as '$generatorConfiguration'.
    Open

        public function process(Schema $schema, GeneratorConfiguration $generatorConfiguration): void
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    syntax error, unexpected ')'
    Open

                        );
    Severity: Critical
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phan

    Multi-line use declarations must define one parameter per line
    Open

                        ) use ($schemaProperties, $validator): array {
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 20
    Open

                        },
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 24
    Open

                            if (in_array($property->getName(), $schemaProperties) &&
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Closing brace must be on a line by itself
    Open

                public function __construct(private array $patternHashes) {}
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Opening brace should be on a new line
    Open

                public function __construct(private array $patternHashes) {}
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Line indented incorrectly; expected 20 spaces, found 24
    Open

                            }
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Opening brace should be on a new line
    Open

        private function addPatternPropertiesMapProperty(Schema $schema): void {
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 20
    Open

                        static function (
    Severity: Minor
    Found in src/SchemaProcessor/PostProcessor/Internal/PatternPropertiesPostProcessor.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status