wol-soft/php-json-schema-model-generator

View on GitHub
src/SchemaProcessor/PostProcessor/Internal/SerializationPostProcessor.php

Summary

Maintainability
C
7 hrs
Test Coverage
A
100%

Function addSerializeFunctionsForTransformingFilters has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function addSerializeFunctionsForTransformingFilters(
        Schema $schema,
        GeneratorConfiguration $generatorConfiguration,
    ): void {
        foreach ($schema->getProperties() as $property) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addSerializeFunctionsForTransformingFilters has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addSerializeFunctionsForTransformingFilters(
        Schema $schema,
        GeneratorConfiguration $generatorConfiguration,
    ): void {
        foreach ($schema->getProperties() as $property) {

    Method addAdditionalPropertiesSerialization has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function addAdditionalPropertiesSerialization(
            Schema $schema,
            GeneratorConfiguration $generatorConfiguration,
        ): void {
            $validationProperty = null;

      Function addAdditionalPropertiesSerialization has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addAdditionalPropertiesSerialization(
              Schema $schema,
              GeneratorConfiguration $generatorConfiguration,
          ): void {
              $validationProperty = null;

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method addSerializeFunctionsForTransformingFilters() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          private function addSerializeFunctionsForTransformingFilters(
              Schema $schema,
              GeneratorConfiguration $generatorConfiguration,
          ): void {
              foreach ($schema->getProperties() as $property) {

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The class SerializationPostProcessor has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
      Open

      class SerializationPostProcessor extends PostProcessor
      {
          /**
           * Add serialization support to the provided schema
           */

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
          /**
           * @var \foo\bar\X
           */
          private $x = null;
      
          /**
           * @var \foo\bar\Y
           */
          private $y = null;
      
          /**
           * @var \foo\bar\Z
           */
          private $z = null;
      
          public function setFoo(\Foo $foo) {}
          public function setBar(\Bar $bar) {}
          public function setBaz(\Baz $baz) {}
      
          /**
           * @return \SplObjectStorage
           * @throws \OutOfRangeException
           * @throws \InvalidArgumentException
           * @throws \ErrorException
           */
          public function process(\Iterator $it) {}
      
          // ...
      }

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      syntax error, unexpected ')', expecting variable (T_VARIABLE)
      Open

          ): void {

      Line indented incorrectly; expected 8 spaces, found 12
      Open

                  static fn(PropertyInterface $property): string => $property->getAttribute(true),

      Multi-line function call not indented correctly; expected 16 spaces but found 20
      Open

                          !$property->isRequired() && !$property->getDefaultValue(),

      Line indented incorrectly; expected 8 spaces, found 16
      Open

                      static fn(PropertyInterface $property): bool =>

      There are no issues that match your filters.

      Category
      Status