Sign upLogin

wol-soft/php-json-schema-model-generator

View on GitHub
Star
src/SchemaProvider/RecursiveDirectoryProvider.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid assigning values to variables in if clauses and the like (line '56', column '35').
Open

    public function getSchemas(): iterable
    {
        $directory = new RecursiveDirectoryIterator($this->sourceDirectory);
        $iterator = new RecursiveIteratorIterator($directory);
        $schemaFiles = [];
Severity: Minor
Found in src/SchemaProvider/RecursiveDirectoryProvider.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private string $sourceDirectory;
Severity: Critical
Found in src/SchemaProvider/RecursiveDirectoryProvider.php by phan

There are no issues that match your filters.

Category
Status