src/Utils/ArrayHash.php
Function hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function hash(array $array, array $relevantFields = []): string
{
if ($relevantFields) {
foreach ($array as $key => $_) {
if (!in_array($key, $relevantFields)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$_'. Open
Open
foreach ($array as $key => $_) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Method name "ArrayHash::array_multiksort" is not in camel caps format Open
Open
private static function array_multiksort(array &$array): void- Exclude checks
The variable $_ is not named in camelCase. Open
Open
public static function hash(array $array, array $relevantFields = []): string
{
if ($relevantFields) {
foreach ($array as $key => $_) {
if (!in_array($key, $relevantFields)) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method array_multiksort is not named in camelCase. Open
Open
private static function array_multiksort(array &$array): void
{
foreach ($array as &$value) {
if (is_array($value)) {
self::array_multiksort($value);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}