Sign upLogin

wol-soft/php-micro-template

View on GitHub
Star

Showing 13 of 13 total issues

The class Render has an overall complexity of 50 which is very high. The configured complexity threshold is 50.
Open

class Render
{
    private const REGEX_VARIABLE = '(?<expression>(?<variable>(\w+|\'[^\']+\'))(?<nestedVariable>(\.\w+)*)(?<methodCall>\((?<parameter>[^{}%]*)\))?)';

    /** @var array */
Severity: Minor
Found in src/Render.php by phpmd

Function resolveNestedVariable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function resolveNestedVariable(&$resolved, array $variablePath, array $matches): bool
    {
        foreach ($variablePath as $variable) {
            if (is_object($resolved) && !($resolved instanceof ArrayAccess)) {
                if (property_exists($resolved, $variable)) {
Severity: Minor
Found in src/Render.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getValue has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getValue(array $matches, array $variables)
    {
        $resolved     = $variables;
        $variablePath = [$matches['variable']];
Severity: Minor
Found in src/Render.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method methodCall has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function methodCall(array $matches, array $variablePath, array $variables)
    {
        $resolved = $variables;
        $method = array_pop($variablePath);
Severity: Minor
Found in src/Render.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $this->methodCall($matches, $variablePath, $variables);
    Severity: Major
    Found in src/Render.php - About 30 mins to fix

      Function methodCall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function methodCall(array $matches, array $variablePath, array $variables)
    {
        $resolved = $variables;
        $method = array_pop($variablePath);
      Severity: Minor
      Found in src/Render.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method getValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $variable = trim($matches['variable']);
            if ($variable === 'true' || $variable === 'false') {
                return $variable === 'true';
            }
      Severity: Minor
      Found in src/Render.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Line exceeds 120 characters; contains 150 characters
      Open

          private const REGEX_VARIABLE = '(?<expression>(?<variable>(\w+|\'[^\']+\'))(?<nestedVariable>(\.\w+)*)(?<methodCall>\((?<parameter>[^{}%]*)\))?)';
      Severity: Minor
      Found in src/Render.php by phpcodesniffer

      Line exceeds 120 characters; contains 132 characters
      Open

                  '/\{%\s*foreach(?<index>-[\d]+-[\d]+-)\s+' . self::REGEX_VARIABLE . '\s+as\s+((?<key>\w+)\s*,\s*)?(?<value>\w+)\s*%\}' .
      Severity: Minor
      Found in src/Render.php by phpcodesniffer

      Reduce the number of returns of this function 5, down to the maximum allowed 3.
      Open

          protected function getValue(array $matches, array $variables)
      Severity: Major
      Found in src/Render.php by sonar-php

      Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

      Noncompliant Code Example

      With the default threshold of 3:

      function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

      Invalid offset 0 of array type array{}
      Open

                      $levelCounter[$structureDepthCounter] = $levelCounter[$structureDepthCounter] ?? 0;
      Severity: Minor
      Found in src/Render.php by phan

      Argument 3 (vars) is null but \sprintf() takes float|int|string
      Open

                              $levelCounter[$structureDepthCounter - 1],
      Severity: Minor
      Found in src/Render.php by phan

      Invalid offset -1 of array type array{}
      Open

                              $levelCounter[$structureDepthCounter - 1],
      Severity: Minor
      Found in src/Render.php by phan
      Severity
      Category
      Status
      Source
      Language