Sign upLogin

wongjiahau/ttap-web

View on GitHub
Star

Showing 211 of 211 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  for (let i = 0; i < timetables.length; i++) {
    for (let j = 0; j < 7; j++) {
      result[j] &= timetables[i].DayTimeMatrix[j];
    }
  }
Severity: Major
Found in src/ts/model/matrix/generateTotalMatrix.ts and 1 other location - About 1 hr to fix
src/ts/model/matrix/generateTotalMatrix.ts on lines 94..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public render() {
    if (this.state.redirect) {
      return <Redirect push={true} to="/login" />;
    }
Severity: Minor
Found in src/ts/react/tutorial/tutorial.tsx - About 1 hr to fix

    Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public render() {
    const menuButton = (
      <IconButton onClick={this.handleOpenDrawer}>
        <MenuIcon />
      </IconButton>
    Severity: Minor
    Found in src/ts/react/app.tsx - About 1 hr to fix

      Function LoadSlotsFromUrl has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export const LoadSlotsFromUrl = (
  downloadUrl: string,
  fileType: string,
  started: () => void,
  successed: (loadedSlots: IRawSlot[]) => void,
      Severity: Minor
      Found in src/ts/react/selectCourseView.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function GeneralizeSlot has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export function GeneralizeSlot(originalSlots: RawSlot[]): RawSlot[] {
  const slots = originalSlots.map(clone) as IRawSlot[];
  const results = new Array<RawSlot>();
  results.push(slots[0]);
  let generalized: boolean;
      Severity: Minor
      Found in src/ts/permutator/generalizeSlot.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export function IsRawSlotEquals(a: IRawSlot, b: IRawSlot): boolean {
  return (
    JSON.stringify(omit(a, ["Uid", "ClassSize", "Remark"])) ===
    JSON.stringify(omit(b, ["Uid", "ClassSize", "Remark"]))
  );
      Severity: Major
      Found in src/ts/parser/parseFgoHtmlToRawSlot_v2.ts and 1 other location - About 1 hr to fix
      src/ts/parser/parseFgoHtmlToRawSlot.ts on lines 94..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export function IsRawSlotEquals(a: IRawSlot, b: IRawSlot): boolean {
  return (
    JSON.stringify(omit(a, ["Uid", "ClassSize", "Remark"])) ===
    JSON.stringify(omit(b, ["Uid", "ClassSize", "Remark"]))
  );
      Severity: Major
      Found in src/ts/parser/parseFgoHtmlToRawSlot.ts and 1 other location - About 1 hr to fix
      src/ts/parser/parseFgoHtmlToRawSlot_v2.ts on lines 98..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public render() {
    const getListItem = (text: string, icon: any, handler: any) => {
      return (
        <ListItem button={true} onClick={handler}>
          <ListItemIcon>{icon}</ListItemIcon>
      Severity: Minor
      Found in src/ts/react/saveTimetableDialog.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (state && state.dragging) {
      out.top = Math.round(state.dragging.top);
      out.left = Math.round(state.dragging.left);
    }
        Severity: Major
        Found in src/ts/modified_node_modules/react-grid-layout/build/GridItem.js and 1 other location - About 1 hr to fix
        src/ts/modified_node_modules/react-grid-layout/build/GridItem.js on lines 96..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (state && state.resizing) {
      out.width = Math.round(state.resizing.width);
      out.height = Math.round(state.resizing.height);
    }
        Severity: Major
        Found in src/ts/modified_node_modules/react-grid-layout/build/GridItem.js and 1 other location - About 1 hr to fix
        src/ts/modified_node_modules/react-grid-layout/build/GridItem.js on lines 101..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function plotPartition has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public plotPartition(partition: T[][], partitionHeadings: string[]): void {
    // calculate full search path count
    this.fullSearchPathCount = this.setPartitionCount(
      partition.map((x) => x.length)
    );
        Severity: Minor
        Found in src/ts/permutator/findTimetableVisualizer.ts - About 1 hr to fix

          Function GenerateErrorLabels has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function GenerateErrorLabels(diffReports: DiffReport[] | null) {
  const errorStyle: React.CSSProperties = {
    color: Colors.Red,
  };
  if (!diffReports) {
          Severity: Minor
          Found in src/ts/react/slotsTableView.tsx - About 1 hr to fix

            Function Report has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const Report = (props: {
  numberOfRemovedTimetables: number;
  numberOfRemainingTimetables: number;
}) => {
  const style: React.CSSProperties = {
            Severity: Minor
            Found in src/ts/react/setTimeConstraintView.tsx - About 1 hr to fix

              Function GenerateStateViews has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function GenerateStateViews(
  states: STCBox[],
  handleSetTimeContraintAt: (state: STCBox) => void,
  handleDesetTimeConstraintAt: (state: STCBox) => void
): ISkeleton {
              Severity: Minor
              Found in src/ts/react/timetableView/generateStateView.tsx - About 1 hr to fix

                Function GenerateSlotViewsAndDayColumn has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function GenerateSlotViewsAndDayColumn(
  slots: ISlotViewModel[],
  selectSlotChoiceHandler: (slotUid: number, newSlotChoice: number) => void,
  goToThisAlternativeSlotHandler: (
    sourceSlotUid: number,
                Severity: Minor
                Found in src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx - About 1 hr to fix

                  Function GenerateNewState has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    protected GenerateNewState(state: IMasterState): IMasterState {
    if (
      state.TimetableListState.ShowingAlternateSlotOf &&
      this.slot.Uid !== state.TimetableListState.ShowingAlternateSlotOf.Uid
    ) {
                  Severity: Minor
                  Found in src/ts/redux/actions/showAlternateSlot.ts - About 1 hr to fix

                    Function ParseStudentHtmlToRawSlot has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export default function ParseStudentHtmlToRawSlot(html: string): RawSlot[] {
  const result = new Array<RawSlot>();
  const htmlDoc = new DOMParser().parseFromString(html, "text/html");
  // @ts-ignore
  const tableRows = htmlDoc
                    Severity: Minor
                    Found in src/ts/parser/parseStudentHtmlToRawSlot.ts - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function ResponsiveReactGridLayout has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    var ResponsiveReactGridLayout = function (_React$Component) {
  _inherits(ResponsiveReactGridLayout, _React$Component);

  function ResponsiveReactGridLayout() {
    var _temp, _this, _ret;
                    Severity: Minor
                    Found in src/ts/modified_node_modules/react-grid-layout/build/ResponsiveReactGridLayout.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function ParseFgoHtmlToRawSlot_v2 has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function ParseFgoHtmlToRawSlot_v2(html: string): RawSlot[] {
  const result = new Array<RawSlot>();
  const htmlDoc = new DOMParser().parseFromString(html, "text/html");

  const tableRows = htmlDoc
                    Severity: Minor
                    Found in src/ts/parser/parseFgoHtmlToRawSlot_v2.ts - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function ParseFgoHtmlToRawSlot_v1 has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function ParseFgoHtmlToRawSlot_v1(html: string): RawSlot[] {
  const result = new Array<RawSlot>();
  const htmlDoc = new DOMParser().parseFromString(html, "text/html");

  const tableRows = htmlDoc
                    Severity: Minor
                    Found in src/ts/parser/parseFgoHtmlToRawSlot.ts - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language