Sign upLogin

wongjiahau/ttap-web

View on GitHub
Star
src/ts/modified_node_modules/react-grid-layout/build/utils.js

Summary

Maintainability
D
2 days
Test Coverage

File utils.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//@ts-nocheck
'use strict';

exports.__esModule = true;
Severity: Minor
Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 3 hrs to fix

    Function moveElement has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    function moveElement(layout, l, x, y, isUserAction, preventCollision, compactType, cols) {
  if (l.static) return layout;

  // Short-circuit if nothing to do.
  if (l.y === y && l.x === x) return layout;
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function moveElementAwayFromCollision has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function moveElementAwayFromCollision(layout, collidesWith, itemToMove, isUserAction, compactType, cols) {

  var compactH = compactType === 'horizontal';
  var compactV = compactType === 'vertical';
  var preventCollision = false; // we're already colliding
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compactItem has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function compactItem(compareWith, l, compactType, cols) {
  var compactV = compactType === 'vertical';
  var compactH = compactType === 'horizontal';
  if (compactV) {
    // Bottom 'y' possible is the bottom of the layout.
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateLayout has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function validateLayout(layout, contextName) {
  contextName = contextName || "Layout";
  var subProps = ['x', 'y', 'w', 'h'];
  if (!Array.isArray(layout)) throw new Error(contextName + " must be an array!");
  for (var _i8 = 0, len = layout.length; _i8 < len; _i8++) {
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function correctBounds has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function correctBounds(layout, bounds) {
  var collidesWith = getStatics(layout);
  for (var _i4 = 0, len = layout.length; _i4 < len; _i4++) {
    var l = layout[_i4];
    // Overflows right
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function moveElement has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function moveElement(layout, l, x, y, isUserAction, preventCollision, compactType, cols) {
  if (l.static) return layout;

  // Short-circuit if nothing to do.
  if (l.y === y && l.x === x) return layout;
    Severity: Minor
    Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

      Function compactItem has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function compactItem(compareWith, l, compactType, cols) {
  var compactV = compactType === 'vertical';
  var compactH = compactType === 'horizontal';
  if (compactV) {
    // Bottom 'y' possible is the bottom of the layout.
      Severity: Minor
      Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

        Function synchronizeLayoutWithChildren has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function synchronizeLayoutWithChildren(initialLayout, children, cols, compactType) {
  return initialLayout;  // Added this line
  initialLayout = initialLayout || [];

  // Generate one layout item per child.
        Severity: Minor
        Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

          Function moveElement has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function moveElement(layout, l, x, y, isUserAction, preventCollision, compactType, cols) {
          Severity: Major
          Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 1 hr to fix

            Function moveElementAwayFromCollision has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function moveElementAwayFromCollision(layout, collidesWith, itemToMove, isUserAction, compactType, cols) {
            Severity: Minor
            Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                return true; // boxes overlap
              Severity: Major
              Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if (l1.y >= l2.y + l2.h) return false; // l1 is below l2
                Severity: Major
                Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 30 mins to fix

                  Function _extends has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };
                  Severity: Minor
                  Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };
                  Severity: Major
                  Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js and 4 other locations - About 3 hrs to fix
                  src/ts/modified_node_modules/react-grid-layout/build/GridItem.js on lines 6..6
                  src/ts/modified_node_modules/react-grid-layout/build/ReactGridLayout.js on lines 6..6
                  src/ts/modified_node_modules/react-grid-layout/build/ResponsiveReactGridLayout.js on lines 6..6
                  src/ts/modified_node_modules/react-grid-layout/build/components/WidthProvider.js on lines 6..6

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 114.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (a.x > b.x || a.x === b.x && a.y > b.y) {
      return 1;
    }
                  Severity: Minor
                  Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js and 1 other location - About 35 mins to fix
                  src/ts/modified_node_modules/react-grid-layout/build/utils.js on lines 415..420

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (a.y > b.y || a.y === b.y && a.x > b.x) {
      return 1;
    } else if (a.y === b.y && a.x === b.x) {
      // Without this, we can get different sort results in IE vs. Chrome/FF
      return 0;
                  Severity: Minor
                  Found in src/ts/modified_node_modules/react-grid-layout/build/utils.js and 1 other location - About 35 mins to fix
                  src/ts/modified_node_modules/react-grid-layout/build/utils.js on lines 427..429

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status