Sign upLogin

wongjiahau/ttap-web

View on GitHub
Star
src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function GenerateSlotViewsAndDayColumn has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function GenerateSlotViewsAndDayColumn(
  slots: ISlotViewModel[],
  selectSlotChoiceHandler: (slotUid: number, newSlotChoice: number) => void,
  goToThisAlternativeSlotHandler: (
    sourceSlotUid: number,
Severity: Minor
Found in src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx - About 1 hr to fix

    Function slotViews has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const slotViews = slots.map((x, index) => {
    return (
      // "s" means "Slot"
      <div key={"s" + index}>
        <SlotView
    Severity: Minor
    Found in src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx - About 1 hr to fix

      Function GenerateSlotViewsAndDayColumn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function GenerateSlotViewsAndDayColumn(
  slots: ISlotViewModel[],
  selectSlotChoiceHandler: (slotUid: number, newSlotChoice: number) => void,
  goToThisAlternativeSlotHandler: (
    sourceSlotUid: number,
      Severity: Minor
      Found in src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function GenerateSlotViewsAndDayColumn has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        slots: ISlotViewModel[],
  selectSlotChoiceHandler: (slotUid: number, newSlotChoice: number) => void,
  goToThisAlternativeSlotHandler: (
    sourceSlotUid: number,
    destinationSlotUid: number
      Severity: Minor
      Found in src/ts/react/timetableView/generateSlotViewsAndDayColumn.tsx - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status