Sign upLogin

wongjiahau/ttap-web

View on GitHub
Star
src/ts/redux/actions/toggleSubjectSelection.ts

Summary

Maintainability
C
1 day
Test Coverage

Function ReleaseDisabledSubjectsIfPossible has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

export function ReleaseDisabledSubjectsIfPossible(
  selectedSubjects: Subject[],
  allSubjects: Subject[]
): void {
  const disabledSubjects = allSubjects.filter((s) => s.ClashReport !== null);
Severity: Minor
Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GenerateNewState has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected GenerateNewState(state: IMasterState): IMasterState {
    const visualizer = state.AlgorithmVisualizerState.isEnabled
      ? new FindTimetableVisualizer()
      : new NullFindTimetableVisualizer();
Severity: Minor
Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 1 hr to fix

    Function ReleaseDisabledSubjectsIfPossible has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function ReleaseDisabledSubjectsIfPossible(
  selectedSubjects: Subject[],
  allSubjects: Subject[]
): void {
  const disabledSubjects = allSubjects.filter((s) => s.ClashReport !== null);
    Severity: Minor
    Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 1 hr to fix

      Function SelectSubject has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function SelectSubject(
  subjectToBeSelected: Subject,
  allSubjects: Subject[],
  state: IMasterState
): IMasterState {
      Severity: Minor
      Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 1 hr to fix

        Function DeselectSubject has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function DeselectSubject(
  subjectToBeDeselected: Subject,
  allSubjects: Subject[],
  state: IMasterState
): IMasterState {
        Severity: Minor
        Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 1 hr to fix

          Function GenerateNewState has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            protected GenerateNewState(state: IMasterState): IMasterState {
    const visualizer = state.AlgorithmVisualizerState.isEnabled
      ? new FindTimetableVisualizer()
      : new NullFindTimetableVisualizer();
          Severity: Minor
          Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function CheckForClashesBetween has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export function CheckForClashesBetween(
  s: Subject,
  subjects: Subject[]
): ClashReport | null {
  for (let i = 0; i < subjects.length; i++) {
          Severity: Minor
          Found in src/ts/redux/actions/toggleSubjectSelection.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status