Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php

Summary

Maintainability
D
2 days
Test Coverage

Method output has 277 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function output( $post ) {
        wp_nonce_field( 'woocommerce_save_data', 'woocommerce_meta_nonce' );

        $coupon_id = absint( $post->ID );
        $coupon    = new WC_Coupon( $coupon_id );
Severity: Major
Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php - About 1 day to fix

    File class-wc-meta-box-coupon-data.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Coupon Data
 *
 * Display the coupon data meta box.
    Severity: Minor
    Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php - About 3 hrs to fix

      Function output has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function output( $post ) {
        wp_nonce_field( 'woocommerce_save_data', 'woocommerce_meta_nonce' );

        $coupon_id = absint( $post->ID );
        $coupon    = new WC_Coupon( $coupon_id );
      Severity: Minor
      Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function save( $post_id, $post ) {
        // Check for dupe coupons.
        $coupon_code  = wc_format_coupon_code( $post->post_title );
        $id_from_code = wc_get_coupon_id_by_code( $coupon_code, $post_id );
      Severity: Minor
      Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            woocommerce_wp_text_input(
                        array(
                            'id'                => 'limit_usage_to_x_items',
                            'label'             => __( 'Limit usage to X items', 'woocommerce' ),
                            'placeholder'       => esc_attr__( 'Apply to all qualifying items in cart', 'woocommerce' ),
        Severity: Major
        Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php and 1 other location - About 1 hr to fix
        includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php on lines 324..339

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            woocommerce_wp_text_input(
                        array(
                            'id'                => 'usage_limit_per_user',
                            'label'             => __( 'Usage limit per user', 'woocommerce' ),
                            'placeholder'       => esc_attr__( 'Unlimited usage', 'woocommerce' ),
        Severity: Major
        Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php and 1 other location - About 1 hr to fix
        includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php on lines 306..321

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                                foreach ( $product_ids as $product_id ) {
                            $product = wc_get_product( $product_id );
                            if ( is_object( $product ) ) {
                                echo '<option value="' . esc_attr( $product_id ) . '"' . selected( true, true, false ) . '>' . esc_html( wp_strip_all_tags( $product->get_formatted_name() ) ) . '</option>';
                            }
        Severity: Major
        Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php and 4 other locations - About 1 hr to fix
        includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php on lines 194..199
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 19..24
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 37..42
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 53..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                                foreach ( $product_ids as $product_id ) {
                            $product = wc_get_product( $product_id );
                            if ( is_object( $product ) ) {
                                echo '<option value="' . esc_attr( $product_id ) . '"' . selected( true, true, false ) . '>' . esc_html( wp_strip_all_tags( $product->get_formatted_name() ) ) . '</option>';
                            }
        Severity: Major
        Found in includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php and 4 other locations - About 1 hr to fix
        includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php on lines 212..217
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 19..24
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 37..42
        includes/admin/meta-boxes/views/html-product-data-linked-products.php on lines 53..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status