Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/admin/meta-boxes/class-wc-meta-box-order-data.php

Summary

Maintainability
F
1 wk
Test Coverage

Function output has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
Open

    public static function output( $post ) {
        global $theorder;

        if ( ! is_object( $theorder ) ) {
            $theorder = wc_get_order( $post->ID );
Severity: Minor
Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method output has 321 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function output( $post ) {
        global $theorder;

        if ( ! is_object( $theorder ) ) {
            $theorder = wc_get_order( $post->ID );
Severity: Major
Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 1 day to fix

    File class-wc-meta-box-order-data.php has 498 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Order Data
 *
 * Functions for displaying the order data meta box.
    Severity: Minor
    Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 7 hrs to fix

      Function save has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function save( $order_id ) {
        self::init_address_fields();

        // Ensure gateways are loaded in case they need to insert data into the emails.
        WC()->payment_gateways();
      Severity: Minor
      Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init_address_fields has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function init_address_fields() {

        self::$billing_fields = apply_filters(
            'woocommerce_admin_billing_fields',
            array(
      Severity: Major
      Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 3 hrs to fix

        Method save has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function save( $order_id ) {
        self::init_address_fields();

        // Ensure gateways are loaded in case they need to insert data into the emails.
        WC()->payment_gateways();
        Severity: Major
        Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( ! empty( self::$billing_fields ) ) {
            foreach ( self::$billing_fields as $key => $field ) {
                if ( ! isset( $field['id'] ) ) {
                    $field['id'] = '_billing_' . $key;
                }
          Severity: Major
          Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php and 1 other location - About 4 hrs to fix
          includes/admin/meta-boxes/class-wc-meta-box-order-data.php on lines 571..587

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 170.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( ! empty( self::$shipping_fields ) ) {
            foreach ( self::$shipping_fields as $key => $field ) {
                if ( ! isset( $field['id'] ) ) {
                    $field['id'] = '_shipping_' . $key;
                }
          Severity: Major
          Found in includes/admin/meta-boxes/class-wc-meta-box-order-data.php and 1 other location - About 4 hrs to fix
          includes/admin/meta-boxes/class-wc-meta-box-order-data.php on lines 552..568

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 170.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status