Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/legacy/api/class-wc-rest-legacy-orders-controller.php

Summary

Maintainability
D
3 days
Test Coverage

Function prepare_item_for_database has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_item_for_database( $request ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $order     = new WC_Order( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
Severity: Minor
Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepare_item_for_database has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_item_for_database( $request ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $order     = new WC_Order( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
Severity: Minor
Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 1 hr to fix

    Method query_args has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function query_args( $args, $request ) {
        global $wpdb;

        // Set post_status.
        if ( 'any' !== $request['status'] ) {
    Severity: Minor
    Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 1 hr to fix

      Method prepare_item_for_response has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function prepare_item_for_response( $post, $request ) {
        $this->request       = $request;
        $this->request['dp'] = is_null( $this->request['dp'] ) ? wc_get_price_decimals() : absint( $this->request['dp'] );
        $statuses            = wc_get_order_statuses();
        $order               = wc_get_order( $post );
      Severity: Minor
      Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 1 hr to fix

        Function query_args has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function query_args( $args, $request ) {
        global $wpdb;

        // Set post_status.
        if ( 'any' !== $request['status'] ) {
        Severity: Minor
        Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if ( isset( $request['billing'] ) || isset( $request['shipping'] ) || isset( $request['line_items'] ) || isset( $request['shipping_lines'] ) || isset( $request['fee_lines'] ) || isset( $request['coupon_lines'] ) ) {
                $order->calculate_totals();
            }
        Severity: Major
        Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 40 mins to fix

          Function create_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function create_order( $request ) {
        try {
            // Make sure customer exists.
            if ( ! is_null( $request['customer_id'] ) && 0 !== $request['customer_id'] && false === get_user_by( 'id', $request['customer_id'] ) ) {
                throw new WC_REST_Exception( 'woocommerce_rest_invalid_customer_id',__( 'Customer ID is invalid.', 'woocommerce' ), 400 );
          Severity: Minor
          Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function update_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function update_order( $request ) {
        try {
            $order = $this->prepare_item_for_database( $request );
            $order->save();
          Severity: Minor
          Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function create_order( $request ) {
        try {
            // Make sure customer exists.
            if ( ! is_null( $request['customer_id'] ) && 0 !== $request['customer_id'] && false === get_user_by( 'id', $request['customer_id'] ) ) {
                throw new WC_REST_Exception( 'woocommerce_rest_invalid_customer_id',__( 'Customer ID is invalid.', 'woocommerce' ), 400 );
          Severity: Major
          Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php and 1 other location - About 1 day to fix
          includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 530..559

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 301.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                              case 'coupon_lines' :
                        if ( is_array( $value ) ) {
                            foreach ( $value as $item ) {
                                if ( is_array( $item ) ) {
                                    if ( $this->item_is_null( $item ) || ( isset( $item['quantity'] ) && 0 === $item['quantity'] ) ) {
          Severity: Major
          Found in includes/legacy/api/class-wc-rest-legacy-orders-controller.php and 3 other locations - About 55 mins to fix
          includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 471..483
          includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 568..580
          includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php on lines 97..109

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 99.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status