Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/legacy/api/v3/class-wc-api-webhooks.php

Summary

Maintainability
F
2 wks
Test Coverage

File class-wc-api-webhooks.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * WooCommerce API Webhooks class
 *
 * Handles requests to the /webhooks endpoint
Severity: Minor
Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 2 hrs to fix

    Function edit_webhook has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function edit_webhook( $id, $data ) {

        try {
            if ( ! isset( $data['webhook'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_webhook_data', sprintf( __( 'No %1$s data specified to edit %1$s', 'woocommerce' ), 'webhook' ), 400 );
    Severity: Minor
    Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method query_webhooks has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function query_webhooks( $args ) {
        $args = $this->merge_query_args( array(), $args );

        $args['limit'] = isset( $args['posts_per_page'] ) ? intval( $args['posts_per_page'] ) : intval( get_option( 'posts_per_page' ) );
    Severity: Minor
    Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

      Method edit_webhook has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit_webhook( $id, $data ) {

        try {
            if ( ! isset( $data['webhook'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_webhook_data', sprintf( __( 'No %1$s data specified to edit %1$s', 'woocommerce' ), 'webhook' ), 400 );
      Severity: Minor
      Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

        Method create_webhook has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function create_webhook( $data ) {

        try {
            if ( ! isset( $data['webhook'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_webhook_data', sprintf( __( 'No %1$s data specified to create %1$s', 'woocommerce' ), 'webhook' ), 400 );
        Severity: Minor
        Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

          Function query_webhooks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function query_webhooks( $args ) {
        $args = $this->merge_query_args( array(), $args );

        $args['limit'] = isset( $args['posts_per_page'] ) ? intval( $args['posts_per_page'] ) : intval( get_option( 'posts_per_page' ) );
          Severity: Minor
          Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validate_request has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function validate_request( $id, $type, $context ) {
        $id = absint( $id );

        // Validate ID.
        if ( empty( $id ) ) {
          Severity: Minor
          Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 1 hr to fix

            Function validate_request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function validate_request( $id, $type, $context ) {
        $id = absint( $id );

        // Validate ID.
        if ( empty( $id ) ) {
            Severity: Minor
            Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create_webhook has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function create_webhook( $data ) {

        try {
            if ( ! isset( $data['webhook'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_webhook_data', sprintf( __( 'No %1$s data specified to create %1$s', 'woocommerce' ), 'webhook' ), 400 );
            Severity: Minor
            Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return $id;
            Severity: Major
            Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return new WP_Error( "woocommerce_api_user_cannot_delete_webhook", sprintf( __( 'You do not have permission to delete this %s', 'woocommerce' ), 'webhook' ), array( 'status' => 401 ) );
              Severity: Major
              Found in includes/legacy/api/v3/class-wc-api-webhooks.php - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php
/**
 * WooCommerce API Webhooks class
 *
 * Handles requests to the /webhooks endpoint
                Severity: Major
                Found in includes/legacy/api/v3/class-wc-api-webhooks.php and 1 other location - About 2 wks to fix
                includes/legacy/api/v2/class-wc-api-webhooks.php on lines 1..509

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 3155.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status