Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php

Summary

Maintainability
F
1 wk
Test Coverage

Method get_item_schema has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => $this->post_type,
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 6 hrs to fix

    File class-wc-rest-order-refunds-v1-controller.php has 384 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API Order Refunds controller
 *
 * Handles requests to the /orders/<order_id>/refunds endpoint.
    Severity: Minor
    Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 5 hrs to fix

      Method prepare_item_for_response has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function prepare_item_for_response( $post, $request ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( ! $order ) {
            return new WP_Error( 'woocommerce_rest_invalid_order_id', __( 'Invalid order ID.', 'woocommerce' ), 404 );
      Severity: Major
      Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 2 hrs to fix

        Method register_routes has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function register_routes() {
        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            'args' => array(
                'order_id'  => array(
                    'description' => __( 'The order ID.', 'woocommerce' ),
        Severity: Major
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 2 hrs to fix

          Function prepare_item_for_response has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public function prepare_item_for_response( $post, $request ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( ! $order ) {
            return new WP_Error( 'woocommerce_rest_invalid_order_id', __( 'Invalid order ID.', 'woocommerce' ), 404 );
          Severity: Minor
          Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_item has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create_item( $request ) {
        if ( ! empty( $request['id'] ) ) {
            /* translators: %s: post type */
            return new WP_Error( "woocommerce_rest_{$this->post_type}_exists", sprintf( __( 'Cannot create existing %s.', 'woocommerce' ), $this->post_type ), array( 'status' => 400 ) );
        }
          Severity: Minor
          Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return new WP_Error( 'woocommerce_rest_cannot_create_order_refund', __( 'Cannot create order refund, please try again.', 'woocommerce' ), 500 );
            Severity: Major
            Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $response;
              Severity: Major
              Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        foreach ( $refund->get_items() as $item_id => $item ) {
            $product      = $item->get_product();
            $product_id   = 0;
            $variation_id = 0;
            $product_sku  = null;
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php and 1 other location - About 2 days to fix
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 175..237

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 539.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function register_routes() {
        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            'args' => array(
                'order_id'  => array(
                    'description' => __( 'The order ID.', 'woocommerce' ),
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php and 1 other location - About 1 day to fix
                includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 59..123

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 401.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 10 locations. Consider refactoring.
                Open

                                            'taxes' => array(
                                'description' => __( 'Line taxes.', 'woocommerce' ),
                                'type'        => 'array',
                                'context'     => array( 'view', 'edit' ),
                                'readonly'    => true,
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php and 9 other locations - About 5 hrs to fix
                includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 474..502
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1281..1309
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1310..1338
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1494..1522
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1558..1586
                includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 494..522
                includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 523..551
                includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1632..1660
                includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1748..1776

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 201.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 10 locations. Consider refactoring.
                Open

                                            'meta' => array(
                                'description' => __( 'Line item meta data.', 'woocommerce' ),
                                'type'        => 'array',
                                'context'     => array( 'view', 'edit' ),
                                'readonly'    => true,
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php and 9 other locations - About 5 hrs to fix
                includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 445..473
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1281..1309
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1310..1338
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1494..1522
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1558..1586
                includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 494..522
                includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 523..551
                includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1632..1660
                includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1748..1776

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 201.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        $links    = array(
            'self' => array(
                'href' => rest_url( sprintf( '/%s/%s/%d', $this->namespace, $base, $refund->get_id() ) ),
            ),
            'collection' => array(
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php and 1 other location - About 1 hr to fix
                includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 623..633

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 113.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status