Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php

Summary

Maintainability
F
6 days
Test Coverage

Method get_item_schema has 220 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => $this->post_type,
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 1 day to fix

    File class-wc-rest-order-refunds-v2-controller.php has 419 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API Order Refunds controller
 *
 * Handles requests to the /orders/<order_id>/refunds endpoint.
    Severity: Minor
    Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 6 hrs to fix

      Method register_routes has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {
        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
            array(
      Severity: Major
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 2 hrs to fix

        Method prepare_object_for_database has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepare_object_for_database( $request, $creating = false ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( ! $order ) {
            return new WP_Error( 'woocommerce_rest_invalid_order_id', __( 'Invalid order ID.', 'woocommerce' ), 404 );
        Severity: Minor
        Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 1 hr to fix

          Method get_formatted_item_data has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function get_formatted_item_data( $object ) {
        $data              = $object->get_data();
        $format_decimal    = array( 'amount' );
        $format_date       = array( 'date_created' );
        $format_line_items = array( 'line_items', 'shipping_lines', 'tax_lines', 'fee_lines' );
          Severity: Minor
          Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 1 hr to fix

            Function prepare_object_for_database has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function prepare_object_for_database( $request, $creating = false ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( ! $order ) {
            return new WP_Error( 'woocommerce_rest_invalid_order_id', __( 'Invalid order ID.', 'woocommerce' ), 404 );
            Severity: Minor
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return apply_filters( "woocommerce_rest_pre_insert_{$this->post_type}_object", $refund, $request, $creating );
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function register_routes() {
        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
            array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php and 1 other location - About 1 day to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 57..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 401.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                                          'meta_data'    => array(
                                'description' => __( 'Meta data.', 'woocommerce' ),
                                'type'        => 'array',
                                'context'     => array( 'view', 'edit' ),
                                'readonly'    => true,
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php and 9 other locations - About 5 hrs to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 445..473
              includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 474..502
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1281..1309
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1310..1338
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1494..1522
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1558..1586
              includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 494..522
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1632..1660
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1748..1776

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 201.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                                          'taxes'        => array(
                                'description' => __( 'Line taxes.', 'woocommerce' ),
                                'type'        => 'array',
                                'context'     => array( 'view', 'edit' ),
                                'readonly'    => true,
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php and 9 other locations - About 5 hrs to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 445..473
              includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 474..502
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1281..1309
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1310..1338
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1494..1522
              includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 1558..1586
              includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 523..551
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1632..1660
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1748..1776

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 201.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 13 locations. Consider refactoring.
              Open

                              'meta_data'        => array(
                    'description' => __( 'Meta data.', 'woocommerce' ),
                    'type'        => 'array',
                    'context'     => array( 'view', 'edit' ),
                    'items'       => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php and 12 other locations - About 4 hrs to fix
              includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php on lines 494..519
              includes/rest-api/Controllers/Version2/class-wc-rest-customers-v2-controller.php on lines 333..358
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1254..1279
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1472..1497
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1563..1588
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1661..1686
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1719..1744
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 965..990
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2240..2265
              includes/rest-api/Controllers/Version3/class-wc-rest-customers-controller.php on lines 276..301
              includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 724..749
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1303..1328

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 177.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status