Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php

Summary

Maintainability
F
5 days
Test Coverage

Method get_item_schema has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'payment_gateway',
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 4 hrs to fix

    File class-wc-rest-payment-gateways-v2-controller.php has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API WC Payment gateways controller
 *
 * Handles requests to the /payment_gateways endpoint.
    Severity: Minor
    Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 3 hrs to fix

      Function update_item has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function update_item( $request ) {
        $gateway = $this->get_gateway( $request );

        if ( is_null( $gateway ) ) {
            return new WP_Error( 'woocommerce_rest_payment_gateway_invalid', __( 'Resource does not exist.', 'woocommerce' ), array( 'status' => 404 ) );
      Severity: Minor
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_item has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function update_item( $request ) {
        $gateway = $this->get_gateway( $request );

        if ( is_null( $gateway ) ) {
            return new WP_Error( 'woocommerce_rest_payment_gateway_invalid', __( 'Resource does not exist.', 'woocommerce' ), array( 'status' => 404 ) );
      Severity: Minor
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 1 hr to fix

        Function get_settings has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_settings( $gateway ) {
        $settings = array();
        $gateway->init_form_fields();
        foreach ( $gateway->form_fields as $id => $field ) {
            // Make sure we at least have a title and type.
        Severity: Minor
        Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method register_routes has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function register_routes() {
        register_rest_route(
            $this->namespace, '/' . $this->rest_base, array(
                array(
                    'methods'             => WP_REST_Server::READABLE,
        Severity: Minor
        Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 1 hr to fix

          Method get_settings has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_settings( $gateway ) {
        $settings = array();
        $gateway->init_form_fields();
        foreach ( $gateway->form_fields as $id => $field ) {
            // Make sure we at least have a title and type.
          Severity: Minor
          Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            'settings'           => array(
                    'description' => __( 'Payment gateway settings.', 'woocommerce' ),
                    'type'        => 'object',
                    'context'     => array( 'view', 'edit' ),
                    'properties'  => array(
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php and 2 other locations - About 2 days to fix
            includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php on lines 481..535
            includes/rest-api/Controllers/Version3/class-wc-rest-payment-gateways-controller.php on lines 166..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 443.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        $data = array(
                'id'          => $id,
                'label'       => empty( $field['label'] ) ? $field['title'] : $field['label'],
                'description' => empty( $field['description'] ) ? '' : $field['description'],
                'type'        => $field['type'],
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php and 1 other location - About 3 hrs to fix
            includes/rest-api/Controllers/Version3/class-wc-rest-payment-gateways-controller.php on lines 87..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 156.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        foreach ( $gateway->form_fields as $key => $field ) {
                if ( isset( $request['settings'][ $key ] ) ) {
                    if ( is_callable( array( $this, 'validate_setting_' . $field['type'] . '_field' ) ) ) {
                        $value = $this->{'validate_setting_' . $field['type'] . '_field'}( $request['settings'][ $key ], $field );
                    } else {
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php and 1 other location - About 3 hrs to fix
            includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php on lines 298..311

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                protected function prepare_links( $gateway, $request ) {
        $links = array(
            'self'       => array(
                'href' => rest_url( sprintf( '/%s/%s/%s', $this->namespace, $this->rest_base, $gateway->id ) ),
            ),
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php and 2 other locations - About 55 mins to fix
            includes/rest-api/Controllers/Version2/class-wc-rest-shipping-methods-v2-controller.php on lines 173..184
            includes/rest-api/Controllers/Version3/class-wc-rest-posts-controller.php on lines 489..500

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status