Sign upLogin

woocommerce/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php

Summary

Maintainability
D
3 days
Test Coverage

Method get_item_schema has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'data_continents',
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php - About 4 hrs to fix

    Method get_continent has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_continent( $continent_code, $request ) {
        $continents  = WC()->countries->get_continents();
        $countries   = WC()->countries->get_countries();
        $states      = WC()->countries->get_states();
        $locale_info = include WC()->plugin_path() . '/i18n/locale-info.php';
    Severity: Major
    Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php - About 2 hrs to fix

      File class-wc-rest-data-continents-controller.php has 253 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * REST API Data continents controller.
 *
 * Handles requests to the /data/continents endpoint.
      Severity: Minor
      Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php - About 2 hrs to fix

        Function get_continent has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_continent( $continent_code, $request ) {
        $continents  = WC()->countries->get_continents();
        $countries   = WC()->countries->get_countries();
        $states      = WC()->countries->get_states();
        $locale_info = include WC()->plugin_path() . '/i18n/locale-info.php';
        Severity: Minor
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method register_routes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function register_routes() {
        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
            array(
        Severity: Minor
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function register_routes() {
        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
            array(
          Severity: Major
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php and 1 other location - About 5 hrs to fix
          includes/rest-api/Controllers/Version3/class-wc-rest-data-countries-controller.php on lines 40..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 186.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                      'states'         => array(
                                'type'        => 'array',
                                'description' => __( 'List of states in this country.', 'woocommerce' ),
                                'context'     => array( 'view' ),
                                'readonly'    => true,
          Severity: Major
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php and 1 other location - About 4 hrs to fix
          includes/rest-api/Controllers/Version3/class-wc-rest-data-countries-controller.php on lines 214..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 163.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              protected function prepare_links( $item ) {
        $continent_code = strtolower( $item['code'] );
        $links          = array(
            'self'       => array(
                'href' => rest_url( sprintf( '/%s/%s/%s', $this->namespace, $this->rest_base, $continent_code ) ),
          Severity: Major
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php and 2 other locations - About 1 hr to fix
          includes/rest-api/Controllers/Version3/class-wc-rest-data-countries-controller.php on lines 175..187
          includes/rest-api/Controllers/Version3/class-wc-rest-data-currencies-controller.php on lines 178..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function get_items( $request ) {
        $continents = WC()->countries->get_continents();
        $data       = array();

        foreach ( array_keys( $continents ) as $continent_code ) {
          Severity: Major
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php and 1 other location - About 1 hr to fix
          includes/rest-api/Controllers/Version3/class-wc-rest-data-countries-controller.php on lines 114..125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function prepare_item_for_response( $item, $request ) {
        $data     = $this->add_additional_fields_to_object( $item, $request );
        $data     = $this->filter_response_by_context( $data, 'view' );
        $response = rest_ensure_response( $data );
          Severity: Minor
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-data-continents-controller.php and 2 other locations - About 35 mins to fix
          includes/rest-api/Controllers/Version3/class-wc-rest-data-countries-controller.php on lines 150..167
          includes/rest-api/Controllers/Version3/class-wc-rest-data-currencies-controller.php on lines 155..170

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status