Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/list-tables/class-wc-admin-list-table-products.php

Summary

Maintainability
D
2 days
Test Coverage

File class-wc-admin-list-table-products.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * List tables: products.
 *
 * @package  WooCommerce\Admin
Severity: Minor
Found in includes/admin/list-tables/class-wc-admin-list-table-products.php - About 4 hrs to fix

    WC_Admin_List_Table_Products has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class WC_Admin_List_Table_Products extends WC_Admin_List_Table {

    /**
     * Post type.
     *
    Severity: Minor
    Found in includes/admin/list-tables/class-wc-admin-list-table-products.php - About 4 hrs to fix

      Method query_filters has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function query_filters( $query_vars ) {
        $this->remove_ordering_args();
        // Custom order by arguments.
        if ( isset( $query_vars['orderby'] ) ) {
            $orderby = strtolower( $query_vars['orderby'] );
      Severity: Minor
      Found in includes/admin/list-tables/class-wc-admin-list-table-products.php - About 1 hr to fix

        Function query_filters has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function query_filters( $query_vars ) {
        $this->remove_ordering_args();
        // Custom order by arguments.
        if ( isset( $query_vars['orderby'] ) ) {
            $orderby = strtolower( $query_vars['orderby'] );
        Severity: Minor
        Found in includes/admin/list-tables/class-wc-admin-list-table-products.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render_name_column has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function render_name_column() {
        global $post;

        $edit_link = get_edit_post_link( $this->object->get_id() );
        $title     = _draft_or_post_title();
        Severity: Minor
        Found in includes/admin/list-tables/class-wc-admin-list-table-products.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function render_product_cat_column() {
        $terms = get_the_terms( $this->object->get_id(), 'product_cat' );
        if ( ! $terms ) {
            echo '<span class="na">&ndash;</span>';
        } else {
          Severity: Major
          Found in includes/admin/list-tables/class-wc-admin-list-table-products.php and 1 other location - About 3 hrs to fix
          includes/admin/list-tables/class-wc-admin-list-table-products.php on lines 239..251

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function render_product_tag_column() {
        $terms = get_the_terms( $this->object->get_id(), 'product_tag' );
        if ( ! $terms ) {
            echo '<span class="na">&ndash;</span>';
        } else {
          Severity: Major
          Found in includes/admin/list-tables/class-wc-admin-list-table-products.php and 1 other location - About 3 hrs to fix
          includes/admin/list-tables/class-wc-admin-list-table-products.php on lines 222..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status