Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/meta-boxes/class-wc-meta-box-product-data.php

Summary

Maintainability
F
3 days
Test Coverage

Function save_variations has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public static function save_variations( $post_id, $post ) {
        // phpcs:disable WordPress.Security.NonceVerification.Missing
        if ( isset( $_POST['variable_post_id'] ) ) {
            $parent = wc_get_product( $post_id );
            $parent->set_default_attributes( self::prepare_set_attributes( $parent->get_attributes(), 'default_attribute_' ) );
Severity: Minor
Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class-wc-meta-box-product-data.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Product Data
 *
 * Displays the product data box, tabbed, with several panels covering price, stock etc.
Severity: Minor
Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 4 hrs to fix

    Method save has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function save( $post_id, $post ) {
        // phpcs:disable WordPress.Security.NonceVerification.Missing
        // Process product type first so we have the correct class to run setters.
        $product_type = empty( $_POST['product-type'] ) ? WC_Product_Factory::get_product_type( $post_id ) : sanitize_title( wp_unslash( $_POST['product-type'] ) );
        $classname    = WC_Product_Factory::get_product_classname( $post_id, $product_type ? $product_type : 'simple' );
    Severity: Major
    Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 3 hrs to fix

      Method save_variations has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function save_variations( $post_id, $post ) {
        // phpcs:disable WordPress.Security.NonceVerification.Missing
        if ( isset( $_POST['variable_post_id'] ) ) {
            $parent = wc_get_product( $post_id );
            $parent->set_default_attributes( self::prepare_set_attributes( $parent->get_attributes(), 'default_attribute_' ) );
      Severity: Major
      Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 3 hrs to fix

        Function prepare_attributes has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function prepare_attributes( $data = false ) {
        $attributes = array();

        if ( ! $data ) {
            $data = stripslashes_deep( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
        Severity: Minor
        Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepare_set_attributes has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function prepare_set_attributes( $all_attributes, $key_prefix = 'attribute_', $index = null ) {
        $attributes = array();

        if ( $all_attributes ) {
            foreach ( $all_attributes as $attribute ) {
        Severity: Minor
        Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_product_data_tabs has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function get_product_data_tabs() {
        $tabs = apply_filters(
            'woocommerce_product_data_tabs',
            array(
                'general'        => array(
        Severity: Minor
        Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 1 hr to fix

          Method prepare_attributes has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function prepare_attributes( $data = false ) {
        $attributes = array();

        if ( ! $data ) {
            $data = stripslashes_deep( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
          Severity: Minor
          Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 1 hr to fix

            Function save has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function save( $post_id, $post ) {
        // phpcs:disable WordPress.Security.NonceVerification.Missing
        // Process product type first so we have the correct class to run setters.
        $product_type = empty( $_POST['product-type'] ) ? WC_Product_Factory::get_product_type( $post_id ) : sanitize_title( wp_unslash( $_POST['product-type'] ) );
        $classname    = WC_Product_Factory::get_product_classname( $post_id, $product_type ? $product_type : 'simple' );
            Severity: Minor
            Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function prepare_downloads has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function prepare_downloads( $file_names, $file_urls, $file_hashes ) {
        $downloads = array();

        if ( ! empty( $file_urls ) ) {
            $file_url_size = count( $file_urls );
            Severity: Minor
            Found in includes/admin/meta-boxes/class-wc-meta-box-product-data.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status