Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/meta-boxes/views/html-variation-admin.php

Summary

Maintainability
D
1 day
Test Coverage

File html-variation-admin.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Outputs a variation for editing.
 *
 * @package WooCommerce\Admin
Severity: Minor
Found in includes/admin/meta-boxes/views/html-variation-admin.php - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <?php if ( $attribute->is_taxonomy() ) : ?>
                    <?php foreach ( $attribute->get_terms() as $option ) : ?>
                        <option <?php selected( $selected_value, $option->slug ); ?> value="<?php echo esc_attr( $option->slug ); ?>"><?php echo esc_html( apply_filters( 'woocommerce_variation_option_name', $option->name, $option, $attribute->get_name(), $product_object ) ); ?></option>
                    <?php endforeach; ?>
                <?php else : ?>
    Severity: Major
    Found in includes/admin/meta-boxes/views/html-variation-admin.php and 1 other location - About 3 hrs to fix
    includes/admin/meta-boxes/views/html-product-data-variations.php on lines 34..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 160.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    woocommerce_wp_text_input(
                    array(
                        'id'                => "variable_download_expiry{$loop}",
                        'name'              => "variable_download_expiry[{$loop}]",
                        'value'             => $variation_object->get_download_expiry( 'edit' ) < 0 ? '' : $variation_object->get_download_expiry( 'edit' ),
    Severity: Major
    Found in includes/admin/meta-boxes/views/html-variation-admin.php and 1 other location - About 2 hrs to fix
    includes/admin/meta-boxes/views/html-variation-admin.php on lines 409..425

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    woocommerce_wp_text_input(
                    array(
                        'id'                => "variable_download_limit{$loop}",
                        'name'              => "variable_download_limit[{$loop}]",
                        'value'             => $variation_object->get_download_limit( 'edit' ) < 0 ? '' : $variation_object->get_download_limit( 'edit' ),
    Severity: Major
    Found in includes/admin/meta-boxes/views/html-variation-admin.php and 1 other location - About 2 hrs to fix
    includes/admin/meta-boxes/views/html-variation-admin.php on lines 427..443

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        woocommerce_wp_select(
                        array(
                            'id'            => "variable_backorders{$loop}",
                            'name'          => "variable_backorders[{$loop}]",
                            'value'         => $variation_object->get_backorders( 'edit' ),
    Severity: Minor
    Found in includes/admin/meta-boxes/views/html-variation-admin.php and 1 other location - About 30 mins to fix
    includes/admin/meta-boxes/views/html-variation-admin.php on lines 229..240

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    woocommerce_wp_select(
                    array(
                        'id'            => "variable_stock_status{$loop}",
                        'name'          => "variable_stock_status[{$loop}]",
                        'value'         => $variation_object->get_stock_status( 'edit' ),
    Severity: Minor
    Found in includes/admin/meta-boxes/views/html-variation-admin.php and 1 other location - About 30 mins to fix
    includes/admin/meta-boxes/views/html-variation-admin.php on lines 200..211

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status