Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/reports/class-wc-report-customer-list.php

Summary

Maintainability
D
1 day
Test Coverage

Method column_default has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function column_default( $user, $column_name ) {
        switch ( $column_name ) {

            case 'customer_name':
                if ( $user->last_name && $user->first_name ) {
Severity: Major
Found in includes/admin/reports/class-wc-report-customer-list.php - About 3 hrs to fix

    Function column_default has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function column_default( $user, $column_name ) {
        switch ( $column_name ) {

            case 'customer_name':
                if ( $user->last_name && $user->first_name ) {
    Severity: Minor
    Found in includes/admin/reports/class-wc-report-customer-list.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_items has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function prepare_items() {
        $current_page = absint( $this->get_pagenum() );
        $per_page     = 20;

        /**
    Severity: Minor
    Found in includes/admin/reports/class-wc-report-customer-list.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return $user_actions;
      Severity: Major
      Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return '<a href="mailto:' . $user->user_email . '">' . $user->user_email . '</a>';
        Severity: Major
        Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return wc_price( wc_get_customer_total_spent( $user->ID ) );
          Severity: Major
          Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return '';
            Severity: Major
            Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return '-';
              Severity: Major
              Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return '<a href="' . admin_url( 'post.php?post=' . $order->get_id() . '&action=edit' ) . '">' . _x( '#', 'hash before order number', 'woocommerce' ) . $order->get_order_number() . '</a> &ndash; ' . wc_format_datetime( $order->get_date_created() );
                Severity: Major
                Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return wc_get_customer_order_count( $user->ID );
                  Severity: Major
                  Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return '-';
                    Severity: Major
                    Found in includes/admin/reports/class-wc-report-customer-list.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function get_columns() {
        $columns = array(
            'customer_name' => __( 'Name (Last, First)', 'woocommerce' ),
            'username'      => __( 'Username', 'woocommerce' ),
            'email'         => __( 'Email', 'woocommerce' ),
                      Severity: Major
                      Found in includes/admin/reports/class-wc-report-customer-list.php and 1 other location - About 2 hrs to fix
                      includes/admin/helper/class-wc-helper.php on lines 358..371

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 135.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status