Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/reports/class-wc-report-downloads.php

Summary

Maintainability
D
1 day
Test Coverage

Function column_default has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function column_default( $item, $column_name ) {
        $permission = null;
        $product    = null;
        try {
            $permission = new WC_Customer_Download( $item->permission_id );
Severity: Minor
Found in includes/admin/reports/class-wc-report-downloads.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function output_report has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function output_report() {

        $this->prepare_items();

        // Subtitle for permission if set.
Severity: Minor
Found in includes/admin/reports/class-wc-report-downloads.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method column_default has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function column_default( $item, $column_name ) {
        $permission = null;
        $product    = null;
        try {
            $permission = new WC_Customer_Download( $item->permission_id );
Severity: Major
Found in includes/admin/reports/class-wc-report-downloads.php - About 2 hrs to fix

    Method output_report has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function output_report() {

        $this->prepare_items();

        // Subtitle for permission if set.
    Severity: Major
    Found in includes/admin/reports/class-wc-report-downloads.php - About 2 hrs to fix

      Method get_items has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function get_items( $current_page, $per_page ) {
        global $wpdb;

        $this->max_items = 0;
        $this->items     = array();
      Severity: Minor
      Found in includes/admin/reports/class-wc-report-downloads.php - About 1 hr to fix

        Function get_items has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_items( $current_page, $per_page ) {
        global $wpdb;

        $this->max_items = 0;
        $this->items     = array();
        Severity: Minor
        Found in includes/admin/reports/class-wc-report-downloads.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                $columns = array(
            'timestamp'       => __( 'Timestamp', 'woocommerce' ),
            'product'         => __( 'Product', 'woocommerce' ),
            'file'            => __( 'File', 'woocommerce' ),
            'order'           => __( 'Order', 'woocommerce' ),
        Severity: Major
        Found in includes/admin/reports/class-wc-report-downloads.php and 2 other locations - About 55 mins to fix
        includes/admin/reports/class-wc-report-downloads.php on lines 83..90
        includes/wc-account-functions.php on lines 89..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                $filter_names = array(
            'product_id'      => __( 'Product', 'woocommerce' ),
            'download_id'     => __( 'File ID', 'woocommerce' ),
            'permission_id'   => __( 'Permission ID', 'woocommerce' ),
            'order_id'        => __( 'Order', 'woocommerce' ),
        Severity: Major
        Found in includes/admin/reports/class-wc-report-downloads.php and 2 other locations - About 55 mins to fix
        includes/admin/reports/class-wc-report-downloads.php on lines 217..224
        includes/wc-account-functions.php on lines 89..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status