woothemes/woocommerce

View on GitHub
includes/admin/reports/class-wc-report-sales-by-product.php

Summary

Maintainability
F
1 wk
Test Coverage

File class-wc-report-sales-by-product.php has 507 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Sales By Product Reporting
 *
 * @package WooCommerce\Admin\Reporting
Severity: Major
Found in includes/admin/reports/class-wc-report-sales-by-product.php - About 1 day to fix

    Method get_main_chart has 189 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_main_chart() {
            global $wp_locale;
    
            if ( empty( $this->product_ids ) ) {
                ?>
    Severity: Major
    Found in includes/admin/reports/class-wc-report-sales-by-product.php - About 7 hrs to fix

      Method products_widget has 169 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function products_widget() {
              ?>
              <h4 class="section_title"><span><?php esc_html_e( 'Product search', 'woocommerce' ); ?></span></h4>
              <div class="section">
                  <form method="GET">
      Severity: Major
      Found in includes/admin/reports/class-wc-report-sales-by-product.php - About 6 hrs to fix

        Method get_chart_legend has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_chart_legend() {
        
                if ( empty( $this->product_ids ) ) {
                    return array();
                }
        Severity: Major
        Found in includes/admin/reports/class-wc-report-sales-by-product.php - About 2 hrs to fix

          Function products_widget has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function products_widget() {
                  ?>
                  <h4 class="section_title"><span><?php esc_html_e( 'Product search', 'woocommerce' ); ?></span></h4>
                  <div class="section">
                      <form method="GET">
          Severity: Minor
          Found in includes/admin/reports/class-wc-report-sales-by-product.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      $order_item_amounts = $this->get_order_report_data(
                          array(
                              'data'         => array(
                                  '_line_total' => array(
                                      'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 5 hrs to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 433..469

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 184.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      $order_item_counts = $this->get_order_report_data(
                          array(
                              'data'         => array(
                                  '_qty'        => array(
                                      'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 5 hrs to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 471..507

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 184.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if ( $top_earners ) {
                              // @codingStandardsIgnoreStart
                              foreach ( $top_earners as $product ) {
                                  echo '<tr class="' . ( in_array( $product->product_id, $this->product_ids ) ? 'active' : '' ) . '">
                                      <td class="count">' . wc_price( $product->order_item_total ) . '</td>
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 2 other locations - About 3 hrs to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 263..275
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 315..327

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 157.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if ( $top_freebies ) {
                              // @codingStandardsIgnoreStart
                              foreach ( $top_freebies as $product ) {
                                  echo '<tr class="' . ( in_array( $product->product_id, $this->product_ids ) ? 'active' : '' ) . '">
                                      <td class="count">' . esc_html( $product->order_item_qty ) . '</td>
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 2 other locations - About 3 hrs to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 263..275
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 360..372

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 157.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if ( $top_sellers ) {
                              // @codingStandardsIgnoreStart
                              foreach ( $top_sellers as $product ) {
                                  echo '<tr class="' . ( in_array( $product->product_id, $this->product_ids ) ? 'active' : '' ) . '">
                                      <td class="count">' . esc_html( $product->order_item_qty ) . '</td>
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 2 other locations - About 3 hrs to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 315..327
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 360..372

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 157.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          $top_freebies = $this->get_order_report_data(
                              array(
                                  'data'         => array(
                                      '_product_id' => array(
                                          'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 2 other locations - About 2 hrs to fix
          includes/admin/reports/class-wc-report-coupon-usage.php on lines 234..264
          includes/admin/reports/class-wc-report-coupon-usage.php on lines 283..313

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          $top_earners = $this->get_order_report_data(
                              array(
                                  'data'         => array(
                                      '_product_id' => array(
                                          'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 1 hr to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 238..261

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          $top_sellers = $this->get_order_report_data(
                              array(
                                  'data'         => array(
                                      '_product_id' => array(
                                          'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 1 hr to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 335..358

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      $this->get_order_report_data(
                          array(
                              'data'         => array(
                                  '_qty' => array(
                                      'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 1 hr to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 67..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $total_sales = $this->get_order_report_data(
                      array(
                          'data'         => array(
                              '_line_total' => array(
                                  'type'            => 'order_item_meta',
          Severity: Major
          Found in includes/admin/reports/class-wc-report-sales-by-product.php and 1 other location - About 1 hr to fix
          includes/admin/reports/class-wc-report-sales-by-product.php on lines 93..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status