Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/settings/class-wc-settings-payment-gateways.php

Summary

Maintainability
C
1 day
Test Coverage

Function payment_gateways_setting has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function payment_gateways_setting() {
        ?>
        <tr valign="top">
        <td class="wc_payment_gateways_wrapper" colspan="2">
            <table class="wc_gateways widefat" cellspacing="0" aria-describedby="payment_gateways_options-description">
Severity: Minor
Found in includes/admin/settings/class-wc-settings-payment-gateways.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method payment_gateways_setting has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function payment_gateways_setting() {
        ?>
        <tr valign="top">
        <td class="wc_payment_gateways_wrapper" colspan="2">
            <table class="wc_gateways widefat" cellspacing="0" aria-describedby="payment_gateways_options-description">
Severity: Major
Found in includes/admin/settings/class-wc-settings-payment-gateways.php - About 3 hrs to fix

    Function output has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function output() {
        global $current_section;

        // Load gateways so we can show any global options they may have.
        $payment_gateways = WC()->payment_gateways->payment_gateways();
    Severity: Minor
    Found in includes/admin/settings/class-wc-settings-payment-gateways.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function save() {
        global $current_section;

        $wc_payment_gateways = WC_Payment_Gateways::instance();
    Severity: Minor
    Found in includes/admin/settings/class-wc-settings-payment-gateways.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                            if ( wc_string_to_bool( $gateway->enabled ) ) {
                                            /* Translators: %s Payment gateway name. */
                                            echo '<a class="button alignright" aria-label="' . esc_attr( sprintf( __( 'Manage the "%s" payment method', 'woocommerce' ), $method_title ) ) . '" href="' . esc_url( admin_url( 'admin.php?page=wc-settings&tab=checkout&section=' . strtolower( $gateway->id ) ) ) . '">' . esc_html__( 'Manage', 'woocommerce' ) . '</a>';
                                        } else {
                                            /* Translators: %s Payment gateway name. */
    Severity: Minor
    Found in includes/admin/settings/class-wc-settings-payment-gateways.php and 1 other location - About 35 mins to fix
    includes/admin/settings/class-wc-settings-payment-gateways.php on lines 177..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                            } else {
                                            /* Translators: %s Payment gateway name. */
                                            echo '<a class="button alignright" aria-label="' . esc_attr( sprintf( __( 'Set up the "%s" payment method', 'woocommerce' ), $method_title ) ) . '" href="' . esc_url( admin_url( 'admin.php?page=wc-settings&tab=checkout&section=' . strtolower( $gateway->id ) ) ) . '">' . esc_html__( 'Set up', 'woocommerce' ) . '</a>';
                                        }
    Severity: Minor
    Found in includes/admin/settings/class-wc-settings-payment-gateways.php and 1 other location - About 35 mins to fix
    includes/admin/settings/class-wc-settings-payment-gateways.php on lines 174..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status