Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/admin/wc-admin-functions.php

Summary

Maintainability
F
4 days
Test Coverage

Function wc_save_order_items has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

function wc_save_order_items( $order_id, $items ) {
    // Allow other plugins to check change in order items before they are saved.
    do_action( 'woocommerce_before_save_order_items', $order_id, $items );

    $qty_change_order_notes = array();
Severity: Minor
Found in includes/admin/wc-admin-functions.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wc_save_order_items has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function wc_save_order_items( $order_id, $items ) {
    // Allow other plugins to check change in order items before they are saved.
    do_action( 'woocommerce_before_save_order_items', $order_id, $items );

    $qty_change_order_notes = array();
Severity: Major
Found in includes/admin/wc-admin-functions.php - About 4 hrs to fix

    File wc-admin-functions.php has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * WooCommerce Admin Functions
 *
 * @package  WooCommerce\Admin\Functions
    Severity: Minor
    Found in includes/admin/wc-admin-functions.php - About 3 hrs to fix

      Method wc_create_page has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function wc_create_page( $slug, $option = '', $page_title = '', $page_content = '', $post_parent = 0 ) {
    global $wpdb;

    $option_value = get_option( $option );
      Severity: Minor
      Found in includes/admin/wc-admin-functions.php - About 2 hrs to fix

        Function wc_create_page has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function wc_create_page( $slug, $option = '', $page_title = '', $page_content = '', $post_parent = 0 ) {
    global $wpdb;

    $option_value = get_option( $option );
        Severity: Minor
        Found in includes/admin/wc-admin-functions.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method wc_maybe_adjust_line_item_product_stock has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function wc_maybe_adjust_line_item_product_stock( $item, $item_quantity = -1 ) {
    if ( 'line_item' !== $item->get_type() ) {
        return false;
    }
        Severity: Minor
        Found in includes/admin/wc-admin-functions.php - About 1 hr to fix

          Function wc_maybe_adjust_line_item_product_stock has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function wc_maybe_adjust_line_item_product_stock( $item, $item_quantity = -1 ) {
    if ( 'line_item' !== $item->get_type() ) {
        return false;
    }
          Severity: Minor
          Found in includes/admin/wc-admin-functions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method wc_render_invalid_variation_notice has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function wc_render_invalid_variation_notice( $product_object ) {
    global $wpdb;

    // Give ability for extensions to hide this notice.
    if ( ! apply_filters( 'woocommerce_show_invalid_variations_notice', true, $product_object ) ) {
          Severity: Minor
          Found in includes/admin/wc-admin-functions.php - About 1 hr to fix

            Method wc_get_screen_ids has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function wc_get_screen_ids() {

    $wc_screen_id = sanitize_title( __( 'WooCommerce', 'woocommerce' ) );
    $screen_ids   = array(
        'toplevel_page_' . $wc_screen_id,
            Severity: Minor
            Found in includes/admin/wc-admin-functions.php - About 1 hr to fix

              Method wc_create_page has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function wc_create_page( $slug, $option = '', $page_title = '', $page_content = '', $post_parent = 0 ) {
              Severity: Minor
              Found in includes/admin/wc-admin-functions.php - About 35 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $new_stock;
                Severity: Major
                Found in includes/admin/wc-admin-functions.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return array(
        'from' => $new_stock + $diff,
        'to'   => $new_stock,
    );
                  Severity: Major
                  Found in includes/admin/wc-admin-functions.php - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        if ( '' === $meta_key && '' === $meta_value ) {
                        if ( ! strstr( $meta_id, 'new-' ) ) {
                            $item->delete_meta_data_by_mid( $meta_id );
                        }
                    } elseif ( strstr( $meta_id, 'new-' ) ) {
                    Severity: Minor
                    Found in includes/admin/wc-admin-functions.php and 1 other location - About 40 mins to fix
                    includes/admin/wc-admin-functions.php on lines 391..399

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        if ( '' === $meta_key && '' === $meta_value ) {
                        if ( ! strstr( $meta_id, 'new-' ) ) {
                            $item->delete_meta_data_by_mid( $meta_id );
                        }
                    } elseif ( strstr( $meta_id, 'new-' ) ) {
                    Severity: Minor
                    Found in includes/admin/wc-admin-functions.php and 1 other location - About 40 mins to fix
                    includes/admin/wc-admin-functions.php on lines 328..336

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status