Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/class-wc-auth.php

Summary

Maintainability
C
1 day
Test Coverage

Method auth_endpoint has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function auth_endpoint( $route ) {
        ob_start();

        $consumer_data = array();
Severity: Major
Found in includes/class-wc-auth.php - About 2 hrs to fix

    Function auth_endpoint has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function auth_endpoint( $route ) {
        ob_start();

        $consumer_data = array();
    Severity: Minor
    Found in includes/class-wc-auth.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_keys has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function create_keys( $app_name, $app_user_id, $scope ) {
        global $wpdb;

        $description = sprintf(
            /* translators: 1: app name 2: scope 3: date 4: time */
    Severity: Minor
    Found in includes/class-wc-auth.php - About 1 hr to fix

      Method make_validation has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function make_validation() {
        $data   = array();
        $params = array(
            'app_name',
            'user_id',
      Severity: Minor
      Found in includes/class-wc-auth.php - About 1 hr to fix

        Function make_validation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function make_validation() {
        $data   = array();
        $params = array(
            'app_name',
            'user_id',
        Severity: Minor
        Found in includes/class-wc-auth.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if ( 'login' === $route && ! is_user_logged_in() ) {
                wc_get_template(
                    'auth/form-login.php', array(
                        'app_name'     => wc_clean( $data['app_name'] ),
                        'return_url'   => add_query_arg(
        Severity: Major
        Found in includes/class-wc-auth.php - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 'write':
                $permissions[] = __( 'Create webhooks', 'woocommerce' );
                $permissions[] = __( 'Create coupons', 'woocommerce' );
                $permissions[] = __( 'Create customers', 'woocommerce' );
                $permissions[] = __( 'Create orders', 'woocommerce' );
          Severity: Minor
          Found in includes/class-wc-auth.php and 1 other location - About 1 hr to fix
          includes/class-wc-auth.php on lines 103..109

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 'read_write':
                $permissions[] = __( 'Create webhooks', 'woocommerce' );
                $permissions[] = __( 'View and manage coupons', 'woocommerce' );
                $permissions[] = __( 'View and manage customers', 'woocommerce' );
                $permissions[] = __( 'View and manage orders and sales reports', 'woocommerce' );
          Severity: Minor
          Found in includes/class-wc-auth.php and 1 other location - About 1 hr to fix
          includes/class-wc-auth.php on lines 96..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status