Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/class-wc-customer.php

Summary

Maintainability
F
3 days
Test Coverage

WC_Customer has 88 functions (exceeds 20 allowed). Consider refactoring.
Open

class WC_Customer extends WC_Legacy_Customer {

    /**
     * Stores customer data.
     *
Severity: Major
Found in includes/class-wc-customer.php - About 1 day to fix

    File class-wc-customer.php has 413 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * The WooCommerce customer class handles storage of the current customer's data, such as location.
 *
 * @package WooCommerce\Classes
    Severity: Minor
    Found in includes/class-wc-customer.php - About 5 hrs to fix

      Function set_address_prop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function set_address_prop( $prop, $address, $value ) {
        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            if ( true === $this->object_read ) {
                if ( $value !== $this->data[ $address ][ $prop ] || ( isset( $this->changes[ $address ] ) && array_key_exists( $prop, $this->changes[ $address ] ) ) ) {
                    $this->changes[ $address ][ $prop ] = $value;
      Severity: Minor
      Found in includes/class-wc-customer.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct( $data = 0, $is_session = false ) {
        parent::__construct( $data );

        if ( $data instanceof WC_Customer ) {
            $this->set_id( absint( $data->get_id() ) );
      Severity: Minor
      Found in includes/class-wc-customer.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function is_customer_outside_base has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function is_customer_outside_base() {
        list( $country, $state ) = $this->get_taxable_address();
        if ( $country ) {
            $default = wc_get_base_location();
            if ( $default['country'] !== $country ) {
      Severity: Minor
      Found in includes/class-wc-customer.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function get_address_prop( $prop, $address = 'billing', $context = 'view' ) {
        $value = null;

        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            $value = isset( $this->changes[ $address ][ $prop ] ) ? $this->changes[ $address ][ $prop ] : $this->data[ $address ][ $prop ];
      Severity: Major
      Found in includes/class-wc-customer.php and 1 other location - About 3 hrs to fix
      includes/class-wc-order.php on lines 532..543

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function set_address_prop( $prop, $address, $value ) {
        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            if ( true === $this->object_read ) {
                if ( $value !== $this->data[ $address ][ $prop ] || ( isset( $this->changes[ $address ] ) && array_key_exists( $prop, $this->changes[ $address ] ) ) ) {
                    $this->changes[ $address ][ $prop ] = $value;
      Severity: Major
      Found in includes/class-wc-customer.php and 1 other location - About 2 hrs to fix
      includes/class-wc-order.php on lines 986..996

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 139.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function set_billing_location( $country, $state = '', $postcode = '', $city = '' ) {
        $address_data = $this->get_prop( 'billing', 'edit' );

        $address_data['address_1'] = '';
        $address_data['address_2'] = '';
      Severity: Major
      Found in includes/class-wc-customer.php and 1 other location - About 1 hr to fix
      includes/class-wc-customer.php on lines 841..852

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function set_shipping_location( $country, $state = '', $postcode = '', $city = '' ) {
        $address_data = $this->get_prop( 'shipping', 'edit' );

        $address_data['address_1'] = '';
        $address_data['address_2'] = '';
      Severity: Major
      Found in includes/class-wc-customer.php and 1 other location - About 1 hr to fix
      includes/class-wc-customer.php on lines 820..831

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status